Conversation
|
Hi 👋, thank you for your PR! We've run benchmarks in an emulated environment. Here are the results: ARM Emulated 32b - lv_conf_perf32b
Detailed Results Per Scene
ARM Emulated 64b - lv_conf_perf64b
Detailed Results Per Scene
Disclaimer: These benchmarks were run in an emulated environment using QEMU with instruction counting mode. 🤖 This comment was automatically generated by a bot. |
There was a problem hiding this comment.
2 issues found across 94 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/misc/lv_style_gen.h">
<violation number="1" location="src/misc/lv_style_gen.h:789">
P2: This header is generated by style_api_gen.py, so adding the new text leading trim API here will be overwritten. Please add the property to style_api_gen.py and regenerate the header instead.
(Based on your team's feedback about treating style_api_gen.py as the source of truth for lv_style_gen.h.) [FEEDBACK_USED]</violation>
</file>
<file name="src/widgets/label/lv_label.c">
<violation number="1" location="src/widgets/label/lv_label.c:852">
P2: Leading-trim draws text outside the object bounds (txt_coords y1/y2), but ext draw size still only uses `font_h/4`. If trims are larger than `font_h/4`, glyphs can be clipped. Update LV_EVENT_REFR_EXT_DRAW_SIZE to include the trim offsets when leading trim is enabled.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| case LV_FONT_GLYPH_FORMAT_A8: { | ||
| const lv_font_t * resolved_font = glyph_draw_dsc->g->resolved_font; | ||
| vg_lite_buffer_t src_buf; | ||
| if(lv_font_has_static_bitmap(resolved_font)) { |
There was a problem hiding this comment.
Encapsulating it into a function makes it easier to understand, so why is this change necessary?
There was a problem hiding this comment.
I wanted to make it fallback to draw_buf creation in case of errors. I updated it.
2c24370 to
1737ae4
Compare
| int32_t cap_height; /**< Cap height of the font*/ | ||
| int32_t x_height; /**< x-height of the font*/ | ||
|
|
There was a problem hiding this comment.
Can we move these right after line_height and base_line attributes to avoid padding bytes as much as possible?
The pointers below should also be moved to the top of the structure too but it's unrelated and can be done in a separate PR if you prefer
Fixes #6131
Continues: #9743
I needed to generate all built-in fonts again, and the bitmaps are formatted differently (e.g.
0x7->0x07) and also there are 1 bit differences in a few cases. I manually reverted the Montserrat 14 font's bitmaps to avoid having too many ref image changes, but in other fonts triggered some very small changes on some images.@FASTSHIFT I also updated how static fonts are handled in VGLite.
This image show what this feature does:

Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle v3.4.12needs to installed by runningcd scripts; ./install_astyle.sh) and follow the Code Conventions.