Repository navigation
Fixed CLI crashing after gem install #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0e8d5ed
declare tty-table as a runtime dependency
HassanAkbar bedf196
make tty-table optional with a plain fallback
HassanAkbar 5a4b5bf
Merge remote-tracking branch 'origin/main' into feat/tty-table-gemspec
HassanAkbar b3e4082
Emit the hint before rendering so retries cannot duplicate
HassanAkbar 970206b
fix dependency guard spec to catch unguarded requires across lib
HassanAkbar f1b5868
fix rubocop offenses in dependencies spec
HassanAkbar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require "spec_helper" | ||
|
|
||
| # The CLI ships as `exe/dcc`. Every gem it requires at load time must be a | ||
| # declared runtime dependency, or `gem install dcc` yields a binary that | ||
| # crashes on every command. | ||
| # rubocop:disable RSpec/DescribeClass -- packaging invariant, not a class | ||
| RSpec.describe "dcc CLI runtime dependencies" do | ||
| let(:root) { File.expand_path("../../..", __dir__) } | ||
| let(:gemspec) { Gem::Specification.load(File.join(root, "dcc.gemspec")) } | ||
| let(:declared) { gemspec.runtime_dependencies.map(&:name) } | ||
| let(:stdlib) do | ||
| %w[base64 bigdecimal csv date digest json open3 openssl set stringio yaml] | ||
| end | ||
|
|
||
| # Matches indented requires (inside a method or conditional) and both quote | ||
| # styles. Does not match parenthesized, multiline, or interpolated requires | ||
| # -- add one of those and this guard will not see it. | ||
| let(:required) do | ||
| pattern = /^\s*require ["']([^"']+)["']/ | ||
| Dir[File.join(root, "lib", "dcc", "cli", "**", "*.rb")] | ||
| .flat_map { |f| File.read(f).scan(pattern).flatten } | ||
| .reject { |name| name.start_with?("dcc/") } | ||
| .map { |name| name.split("/").first } | ||
| .uniq - stdlib | ||
| end | ||
|
|
||
| it "finds the gems the CLI requires" do | ||
| expect(required).to include("thor", "tty-table") | ||
| end | ||
|
|
||
| it "declares every third-party gem the CLI requires" do | ||
| expect(required - declared).to be_empty | ||
| end | ||
| end | ||
| # rubocop:enable RSpec/DescribeClass | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.