fix(mac): validate DMG output and ship ZIP fallback - #9
Closed
luolangaga wants to merge 1 commit into
Closed
luolangaga wants to merge 1 commit into
luolangaga wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Verify generated macOS installers are validstep in.github/workflows/build-mac.ymlthat listsdist, finds the produced*.dmg, runshdiutil verifyon the DMG, and runsunzip -ton a produced*.zipif present.CSC_IDENTITY_AUTO_DISCOVERYto avoid entering a partially-signed broken state when signing secrets are absent, and preserved existing signing/notarization env vars (CSC_LINK,CSC_KEY_PASSWORD,APPLE_ID,APPLE_APP_SPECIFIC_PASSWORD,APPLE_TEAM_ID).*.dmgand*.zipas upload/Release files to provide a ZIP fallback for distribution.package.jsonmac build target to["dmg","zip"]and added mac entitlements files references (assets/macos/entitlements.mac.plistandassets/macos/entitlements.mac.inherit.plist) to ensure CI produces the ZIP fallback and proper entitlements are applied.Testing
package.jsonis parseable withnode -e "JSON.parse(require('fs').readFileSync('package.json','utf8'))", which succeeded.ruby -e "require 'yaml'; YAML.load_file('.github/workflows/build-mac.yml')", which succeeded.git diff --checkstyle checks, which succeeded.hdiutilverification must be validated on GitHub Actions macOS runners; local environment did not execute a full macOS build in this change.Codex Task