Skip to content

LDEV-5629: Add a fix for the cfinvokeargument type issue #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cfmitrah wants to merge 1 commit into
base: 7.1
Choose a base branch
from
+10 −2
Open

LDEV-5629: Add a fix for the cfinvokeargument type issue #2803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core/src/main/java/lucee/runtime/tag/InvokeArgument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import lucee.runtime.exp.ApplicationException;
import lucee.runtime.exp.PageException;
import lucee.runtime.ext.tag.TagImpl;
import lucee.runtime.op.Caster;

// TODO tag invokeargument
// attr omit
Expand All @@ -48,6 +49,13 @@ public final class InvokeArgument extends TagImpl {
* @param value value to set
**/
public void setValue(Object value) {
if (value instanceof String) {
Double d = Caster.toDouble(value, null);
if (d != null) {
this.value = d;
return;
}
}
this.value = value;
}

Expand Down
4 changes: 2 additions & 2 deletions test/tickets/LDEV5629.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ component extends="org.lucee.cfml.test.LuceeTestCase" {

describe( title="Test case LDEV-5629 invoke with tag based cfc", body=function() {

it(title="checking cfinvokeargument preserves types", skip=true, body=function( currentSpec ) {
it(title="checking cfinvokeargument preserves types", body=function( currentSpec ) {
```
<cfinvoke component="LDEV5629.ldev5629_tag" method="testNumbers" returnvariable="local.result">
<cfinvokeargument name="tStr" value="string to test" >
Expand All @@ -27,7 +27,7 @@ component extends="org.lucee.cfml.test.LuceeTestCase" {

describe( title="Test case LDEV-5629 invoke with script based cfc", body=function() {

it(title="checking cfinvokeargument preserves types", skip=true, body=function( currentSpec ) {
it(title="checking cfinvokeargument preserves types", body=function( currentSpec ) {
```
<cfinvoke component="LDEV5629.ldev5629_script" method="testNumbers" returnvariable="local.result">
<cfinvokeargument name="tStr" value="string to test" >
Expand Down
Loading