Issue 133#134
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pixel equalization calibration workflow (Issue 133) by adding support for multiple equalization algorithms and adjusting the CLI/pipeline to accommodate an optional spectrum PDF, plus a small enhancement to calibration matrix validation plots.
Changes:
- Add
"relative"vs"absolute"equalization algorithms and make the SpectrumPDF optional unless needed. - Implement the new relative equalization path in
CalibrateEqualizationusing running per-pixel statistics. - Update CLI/pipeline wiring for the new options and improve
calibviewcorrelation plotting by fitting a slope.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/hexsample/tasks.py | Adds equalization defaults/options, dispatches algorithm, updates calibview correlation plot to use a fitted line model. |
| src/hexsample/pipeline.py | Passes the new algorithm and pdf parameters into the tasks layer. |
| src/hexsample/cli.py | Adds --algorithm and makes --pdf optional for equalization calibration. |
| src/hexsample/calibration.py | Extends CalibrateEqualization with algorithm selection and adds the relative equalization implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.