Remove CURL workarounds#30
Conversation
Replace the non-existent WITH_CUSTOM_HTTP_CLIENT flag with the correct WITH_HTTP_CLIENT_CURL=OFF, which opentelemetry-cpp uses to signal that the caller supplies its own HttpClientFactory transport. Bump third_party/opentelemetry-cpp to e568cc0 (tip of the local fix/issue-24-custom-http-client fork branch), which adds the opentelemetry_http_client interface library and the custom_http_client example that accompanies opentelemetry-cpp PR #4071. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
e26c273 to
4d470c3
Compare
|
@claude adjust this PR to open-telemetry/opentelemetry-cpp#4071 |
|
Claude encountered an error after 12m 52s —— View job Adjusting PR to opentelemetry-cpp #4071
|
|
Claude finished @ltowarek's task in 11m 52s —— View job Adjusting PR to opentelemetry-cpp#4071
What I foundCurrent PR state (branch
Blocker: I attempted every available method to read To unblock me, please choose one optionOption A — Reply to this comment with a brief description of what changed in PR #4071 since commit
Option B — Grant network access by adding to {
"permissions": {
"allow": [
"WebFetch(https://github.com/*)",
"WebFetch(https://api.github.com/*)"
]
}
}Then re-trigger Option C — Grant |
…larity and maintainability
Resolve conflicts from main's src/ → src/integration/ restructuring: - CMakeLists.txt: keep WITH_HTTP_CLIENT_CURL=OFF + opentelemetry_http_client_esp approach; update source/include paths to src/integration/ - cmake/FindCURL.cmake: keep deletion (no longer needed without curl stub) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Update comments in the transport source, header, and README to reflect that libcurl is now excluded entirely via WITH_HTTP_CLIENT_CURL=OFF rather than replaced at the link level. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Fixes #24