Skip to content

Remove CURL workarounds#30

Open
ltowarek wants to merge 5 commits into
mainfrom
fix/issue-24-custom-http-client
Open

Remove CURL workarounds#30
ltowarek wants to merge 5 commits into
mainfrom
fix/issue-24-custom-http-client

Conversation

@ltowarek
Copy link
Copy Markdown
Owner

@ltowarek ltowarek commented May 8, 2026

Fixes #24

ltowarek and others added 2 commits May 12, 2026 20:46
Replace the non-existent WITH_CUSTOM_HTTP_CLIENT flag with the
correct WITH_HTTP_CLIENT_CURL=OFF, which opentelemetry-cpp uses to
signal that the caller supplies its own HttpClientFactory transport.

Bump third_party/opentelemetry-cpp to e568cc0 (tip of the local
fix/issue-24-custom-http-client fork branch), which adds the
opentelemetry_http_client interface library and the custom_http_client
example that accompanies opentelemetry-cpp PR #4071.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ltowarek ltowarek force-pushed the fix/issue-24-custom-http-client branch from e26c273 to 4d470c3 Compare May 12, 2026 21:07
@ltowarek
Copy link
Copy Markdown
Owner Author

@claude adjust this PR to open-telemetry/opentelemetry-cpp#4071

@claude
Copy link
Copy Markdown

claude Bot commented May 16, 2026

Claude encountered an error after 12m 52s —— View job


Adjusting PR to opentelemetry-cpp #4071

  • Gather context: fetch opentelemetry-cpp PR #4071 details
  • Review current state of this repo
  • Understand what changes PR #4071 introduces
  • Adjust this PR accordingly
  • Commit and push changes

@claude
Copy link
Copy Markdown

claude Bot commented May 16, 2026

Claude finished @ltowarek's task in 11m 52s —— View job


Adjusting PR to opentelemetry-cpp#4071

  • Gather context about the current PR state
  • Fetch and analyze opentelemetry-cpp PR #4071 — blocked (network access not available in this runner)
  • Understand what adjustments are needed
  • Implement changes

What I found

Current PR state (branch fix/issue-24-custom-http-client):

  • .gitmodules points the opentelemetry-cpp submodule to your fork (ltowarek/opentelemetry-cpp) at commit e568cc04, which contains the proposed changes from PR #4071
  • CMakeLists.txt uses WITH_HTTP_CLIENT_CURL=OFF and creates an opentelemetry_http_client_esp STATIC target PRIVATE-linked into opentelemetry_exporter_otlp_http_client
  • src/esp_http_client_transport.cpp implements HttpClientFactory::Create() / CreateSync()

Blocker: I attempted every available method to read https://github.com/open-telemetry/opentelemetry-cpp/pull/4071 — WebFetch, gh api, curl, Python urllib, git ls-remote — but all network-accessing calls require user approval and are being denied in this runner session.


To unblock me, please choose one option

Option A — Reply to this comment with a brief description of what changed in PR #4071 since commit e568cc04 on your fork. For example:

  • Did the CMake target name change (e.g., from opentelemetry_http_client to something else)?
  • Did the HttpClientFactory API signatures change?
  • Is there a newer commit on the fork's branch I should pin the submodule to?
  • Or has PR #4071 landed in upstream, meaning we should switch .gitmodules back to open-telemetry/opentelemetry-cpp and update the submodule hash?

Option B — Grant network access by adding to .claude/settings.json:

{
  "permissions": {
    "allow": [
      "WebFetch(https://github.com/*)",
      "WebFetch(https://api.github.com/*)"
    ]
  }
}

Then re-trigger @claude and I can fetch the PR directly.

Option C — Grant git submodule update --init permission so I can read the fork's code directly.

ltowarek and others added 3 commits May 16, 2026 23:03
Resolve conflicts from main's src/ → src/integration/ restructuring:
- CMakeLists.txt: keep WITH_HTTP_CLIENT_CURL=OFF + opentelemetry_http_client_esp
  approach; update source/include paths to src/integration/
- cmake/FindCURL.cmake: keep deletion (no longer needed without curl stub)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Update comments in the transport source, header, and README to reflect
that libcurl is now excluded entirely via WITH_HTTP_CLIENT_CURL=OFF rather
than replaced at the link level.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

opentelemetry-cpp: WITH_OTLP_HTTP=ON hardcodes libcurl as the HTTP transport

1 participant