Skip to content

Cleanup adapter connections - #1023

Merged
technoweenie merged 13 commits into
masterfrom
cleanup-adapter-connections
Oct 17, 2019
Merged

Cleanup adapter connections#1023
technoweenie merged 13 commits into
masterfrom
cleanup-adapter-connections

Conversation

@technoweenie

@technoweenie technoweenie commented Sep 20, 2019

Copy link
Copy Markdown
Member

This adds #build_connection and #connection to the adapters, as suggested in #1006 (comment).

  • TODO
    • excon
    • httpclient
    • net_http_persistent
    • net_http
    • patron
  • SKIP
    • EM HTTP - Is external pooling needed with the EM reactor?
    • EM Synchrony - EM reactor
    • rack - No actual HTTP connection
    • test - No actual HTTP connection
    • typhoeus - Maintained externally. Can file patch later!

@technoweenie
technoweenie marked this pull request as ready for review September 20, 2019 11:36
@technoweenie

technoweenie commented Sep 20, 2019

Copy link
Copy Markdown
Member Author

Fixed this faraday-live failure in f8615d5:

$ FARADAY_GEM_REF=ba7b82d9a2211c4fdd840189e246dbd7a6e4c229 docker-compose build tests
$ docker-compose run tests

  1) net_http_persistent with unverified HTTPS server succeeds with verification disabled
     Failure/Error: res = conn.get('unverified_with_verification')

     Faraday::SSLError:
       SSL_connect returned=1 errno=0 state=error: certificate verify failed (unable to get local issuer certificate)

iMacTia
iMacTia previously approved these changes Sep 20, 2019

@iMacTia iMacTia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardising the different adapters can only benefit us in the future, so big 👍 from me

olleolleolle
olleolleolle previously approved these changes Oct 15, 2019

@olleolleolle olleolleolle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have proof-read all this, and it looks clear.

The new supporting methods help a lot!

@technoweenie
technoweenie merged commit 520e357 into master Oct 17, 2019
@technoweenie
technoweenie deleted the cleanup-adapter-connections branch October 17, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants