Skip to content

perf: skip deep SSTable validation on fast import#1031

Merged
zxch3n merged 2 commits into
mainfrom
perf/skip-sstable-block-validation
Jun 22, 2026
Merged

perf: skip deep SSTable validation on fast import#1031
zxch3n merged 2 commits into
mainfrom
perf/skip-sstable-block-validation

Conversation

@zxch3n

@zxch3n zxch3n commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Skip eager SSTable block decoding/key-order validation when importing through the fast path.
  • Keep per-block checksum verification enabled for both strict and fast imports.
  • Update SSTable tests to cover strict validation and the fast-path behavior.

Validation

  • cargo test -p loro-kv-store
  • cargo test -p loro-internal import_atomicity
  • rustfmt --check crates/kv-store/src/sstable.rs
  • git diff --check
  • cargo bench -p loro-internal --features test_utils --bench encode -- B4_decode_snapshot: [234.50 us 239.03 us 247.50 us]

Note

  • cargo fmt --all --check still reports pre-existing unrelated formatting differences outside this change.

@github-actions

Copy link
Copy Markdown
Contributor

WASM Size Report

  • Original size: 3039.61 KB
  • Gzipped size: 1002.84 KB
  • Brotli size: 703.73 KB

@zxch3n
zxch3n merged commit 3986805 into main Jun 22, 2026
1 check passed
@zxch3n
zxch3n deleted the perf/skip-sstable-block-validation branch June 22, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant