Add pod session log feature and retention#107
Open
EJM0 wants to merge 2 commits into
Open
Conversation
Adds a pod session log with retention controls and UI. - New PodSessionLogRetention enum (OmnipodCommon) with titles and days/forever logic. - Persisted podSessionLog and podSessionLogRetention in OmniPumpManagerState; added recording, pruning, remove/clear helpers, and RawRepresentable serialization. - OmniPumpManager: exposes podSessionLog/podSessionLogDetails, retention property (applies pruning immediately), and methods to delete/clear entries; records completed sessions when a pod ends. - OmniSettingsViewModel: published properties for pod session log details and retention, plus delete/clear actions and observers updates. - UI: adds navigation link in OmniSettingsView and new PodSessionLogView/PodSessionLogListContent implementing retention picker, list, delete, and clear-confirmation UI (with previews).
Contributor
|
Thank you for your contribution. We will look at this. Just a side note for next time. Please always issue PRs from a feature branch based on dev but with a specific branch name, such as add-pod-history or something like that. |
Author
|
Oh ups just noticed I forgot about that. I can redo the pr with a proper brach, if you want? |
Contributor
|
You do not have to redo the PR. Just make sure you do not modify your dev branch for another reason - if you do that, this PR would be updated too. That's one of the many reasons why it is far better to use a named branch for a specific change. |
Author
|
Okay noted 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pod session log with retention controls and UI.
A failure log for the OmniPod module. Since I’m having these 203 failures, I keep finding myself in situations where I need to report multiple pods to my supplier.(in batches) I usually screenshot the failure details and ref codes, but having a built-in log with this info would eliminate the clumsy screenshot mess.