Skip to content

Declare jinja2 as a direct dependency #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkukul wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

Declare jinja2 as a direct dependency #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/568.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Declare `jinja2` as a direct dependency. `fastapi_cache.coder` imports `starlette.templating` unconditionally, which requires jinja2, but jinja2 is only an optional starlette extra (dropped from the base install in Starlette 1.0). This fixes `ImportError: jinja2 must be installed to use Jinja2Templates` on a minimal install.
6 changes: 3 additions & 3 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ uvicorn = "*"
typing-extensions = { version = ">=4.1.0" }
importlib-metadata = { version = "^6.6.0", python = "<3.8" }
pendulum = "^3.0.0"
# coder.py imports starlette.templating unconditionally, which requires jinja2.
# jinja2 is only an optional starlette extra (dropped from the base install in
# Starlette 1.0), so declare it explicitly here.
jinja2 = "*"
aiomcache = { version = "^0.8.2", optional = true }
aiobotocore = {version = "^2.13.1", optional = true}
redis = {version = "^5.0.8", extras = ["redis"]}
Expand Down