Refactor: Extract MVEL extension & Improve Code Quality - #18
Merged
Conversation
…egy to mvel module
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase to extract MVEL-related functionality into a separate module, improving modularity and adhering to the Open-Closed Principle. The changes include creating a new objectmerger-mvel module, implementing a FieldDefinitionTypeAdapterFactory for improved JSON deserialization, applying code formatting (AOSP style), organizing dependencies by scope, and cleaning up wildcard imports.
Changes:
- Created new
objectmerger-mvelmodule to contain MVEL and Conditional merge strategies - Implemented
FieldDefinitionTypeAdapterFactoryto dynamically resolve field definition types based on strategy registry - Applied Spotless code formatting with AOSP style and import order configuration
Reviewed changes
Copilot reviewed 79 out of 125 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Added objectmerger-mvel module and configured Spotless with AOSP style |
| objectmerger/pom.xml | Removed MVEL dependency and reorganized dependencies by scope |
| objectmerger-mvel/pom.xml | New module POM with MVEL dependencies |
| objectmerger-spring-boot/pom.xml | Added objectmerger-mvel as test dependency |
| FieldDefinitionTypeAdapterFactory.java | New type adapter factory for dynamic field definition deserialization |
| MergeDefinitionConverter.java | Simplified to use new FieldDefinitionTypeAdapterFactory |
| Various test files | Moved MVEL-related tests to new module and applied formatting |
| Service provider files | Updated to reflect moved strategies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes