fix: lndhub returns invoice paid, when its pending and maybe failing#52
Merged
Conversation
lnbits introduced a payment timeout and when that is hit, it will return success and paid invoice. fix is to wait until invoice is paid for failed before returning. also! `/gettxs` should not return pending invoices
dni
commented
Mar 27, 2026
| await get_payments( | ||
| wallet_id=key_type.wallet.id, | ||
| pending=True, | ||
| pending=False, |
Member
Author
There was a problem hiding this comment.
another issue, should /gettxs should onlyt return succesful payments taken from the docs. https://github.com/BlueWallet/LndHub/blob/master/doc/Send-requirements.md#get-gettxs
motorina0
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lnbits introduced a payment timeout and when that is hit, it will return success and paid invoice.
fix is to wait until invoice is paid for failed before returning.
also!
/gettxsshould not return pending invoices