Skip to content

[SelectionDAGBuilder] Replace asserts inside LLVM_DEBUG #199748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davemgreen merged 3 commits into from
May 27, 2026
Merged

[SelectionDAGBuilder] Replace asserts inside LLVM_DEBUG #199748

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07525dc
[SelectionDAGBuilder] Replace asserts inside LLVM_DEBUG
davemgreen May 26, 2026
680765e
Merge branch 'main' into gh-dag-debugassert
davemgreen May 27, 2026
fad184f
Merge branch 'main' into gh-dag-debugassert
davemgreen May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12097,14 +12097,8 @@ void SelectionDAGISel::LowerArguments(const Function &F) {
"LowerFormalArguments didn't return a valid chain!");
assert(InVals.size() == Ins.size() &&
"LowerFormalArguments didn't emit the correct number of values!");
LLVM_DEBUG({
for (unsigned i = 0, e = Ins.size(); i != e; ++i) {
assert(InVals[i].getNode() &&
"LowerFormalArguments emitted a null value!");
assert(EVT(Ins[i].VT) == InVals[i].getValueType() &&
"LowerFormalArguments emitted a value with the wrong type!");
}
});
assert(all_of(InVals, [](SDValue InVal) { return InVal.getNode(); }) &&
"LowerFormalArguments emitted a null value!");

// Update the DAG with the new chain value resulting from argument lowering.
DAG.setRoot(NewRoot);
Expand Down