[mlir][SCF] Allow breaking exit from scf.loop#199741
Draft
matthias-springer wants to merge 1 commit into
Draft
Conversation
matthias-springer
changed the title
scf.loopscf.loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalize the MLIR LangRef to allow breaking region exit. A terminator with breaking exit identifies the target operation with a token. All ops on the path from the terminator to the targeted operation must implement the
PropagateControlFlowBreaktrait.scf.loopandscf.ifimplementPropagateControlFlowBreak.scf.ifto allowscf.break,scf.continue,scf.yieldterminators.scf.loopverification. A terminator that targets anscf.loopop may now appear deeply nested within the loop body.SCFToControlFlowbails on breaking region exit. A lowering path will be implemented in a follow-up commit.Partly extracted from: #166688.
Co-authored-by: Mehdi Amini joker.eph@gmail.com
Assisted-by: Opus 4.7
Depends on #199535.