[RTG] Randomizer operations are not pure#10560
Open
maerhart wants to merge 1 commit into
Open
Conversation
seldridge
approved these changes
May 29, 2026
Member
seldridge
left a comment
seldridge
left a comment
There was a problem hiding this comment.
This makes sense to me.
The custom resource is an interesting idea. That is perhaps something we can/should lean on more heavily in other dialects as opposed to reusing generic memory effects.
Comment on lines
+23
to
+25
| // CHECK-NEXT: rtg.set_select_random [[SET]] : !rtg.set<i32> | ||
| // CHECK-NEXT: rtg.set_select_random [[SET]] : !rtg.set<i32> | ||
| // CHECK-NEXT: rtg.set_select_random [[SET]] : !rtg.set<i32> |
Member
There was a problem hiding this comment.
Consider:
Suggested change
| // CHECK-NEXT: rtg.set_select_random [[SET]] : !rtg.set<i32> | |
| // CHECK-NEXT: rtg.set_select_random [[SET]] : !rtg.set<i32> | |
| // CHECK-NEXT: rtg.set_select_random [[SET]] : !rtg.set<i32> | |
| // CHECK-COUNT-3: rtg.set_select_random [[SET]] : !rtg.set<i32> | |
| // CHECK-NOT: rtg.set_select_random [[SET]] |
Same comment throughout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.