[OM] Simplify evaluator placeholder handling, NFCI#10555
Open
uenoku wants to merge 5 commits into
Open
Conversation
uenoku
force-pushed
the
dev/hidetou/om-evaluator-cleanup-2
branch
from
ac9aa35 to
10cb658
Compare
uenoku
changed the title
uenoku
force-pushed
the
dev/hidetou/om-evaluator-cleanup-2
branch
2 times, most recently
from
4223993 to
91f0627
Compare
Remove ReferenceValue indirection and evaluator finalization from the OM evaluator. Object-valued cycles are now represented by preallocated ObjectValue placeholders that are filled once fields are evaluated, so there is no post-evaluation reference-stripping pass. Drop the fully-evaluated counter, worklist, pending-assert flow, parameter-keyed evaluator cache, and recursive ActualParameters threading that existed to resolve ReferenceValue updates. The current instantiation cache is keyed by SSA value, cleared per instantiation, and class parameters are bound once before evaluating the class body. Centralize partial-evaluation checks and use evaluateOp overloads for operation dispatch. Remove the now-obsolete C API and Python bindings for evaluator reference values and update the evaluator tests for the simplified flow.
uenoku
force-pushed
the
dev/hidetou/om-evaluator-cleanup-2
branch
from
91f0627 to
baf9440
Compare
Updated CHECK-SAME loc entries in om.py to use 'fused' instead of '-'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first commit to fully migrate to new evaluation flow, NFCI.
Remove ReferenceValue because there is no ObjectFieldOp in new evaluation flow. Hence we can drop the fully-evaluated counter, worklist. This also removes assertion evaluation since it's checked in the prepass.
During evaluation, only ObjectValue placeholders may remain partially evaluated while fields are being connected.
In following PR partial evaluation flag will be also removed.
Assisted-by: claude code: sonnet 4.6