Skip to content

[LowerToHW] Add support for lower-to-core in firrtl.fprintf#10452

Merged
uenoku merged 4 commits into
llvm:mainfrom
nanjo712:feat/lower-firrtl-fprint-to-sim
May 25, 2026
Merged

[LowerToHW] Add support for lower-to-core in firrtl.fprintf#10452
uenoku merged 4 commits into
llvm:mainfrom
nanjo712:feat/lower-firrtl-fprint-to-sim

Conversation

@nanjo712
Copy link
Copy Markdown
Contributor

Add support for lower-to-core in firrtl.fprintf

Follow up #10450 .

Part of #10131 .

@nanjo712 nanjo712 force-pushed the feat/lower-firrtl-fprint-to-sim branch from c003c46 to e737f90 Compare May 13, 2026 15:21
@nanjo712
Copy link
Copy Markdown
Contributor Author

Hi @fzi-hielscher. I tried implementing the handling of firrtl.fprintf based on your description in #10422, and now sim.get_file is in the same sim.triggered block as sim.proc.print, which uses it. I think this might be the form you want? Please correct me if I've misunderstood.

@fzi-hielscher
Copy link
Copy Markdown
Contributor

Yep, that's what I meant. 👍
We'll also have to update the GetFileOp itself: Make it procedural and note in the description that it has an immediate side-effect (create the file). Maybe it would be easier to do the changes in the core dialects and SV lowering before adding it to the FIRRTL lowering?

@nanjo712
Copy link
Copy Markdown
Contributor Author

That sounds reasonable. I'll first move on to a new PR to handle the changes to GetFileOp, and once that PR is complete, we'll return to this PR to continue.

@nanjo712 nanjo712 force-pushed the feat/lower-firrtl-fprint-to-sim branch from e737f90 to 73af2ca Compare May 15, 2026 08:10
@circt-bot
Copy link
Copy Markdown

circt-bot Bot commented May 15, 2026

Results of circt-tests run for 63fe07a compared to results for 7ffa508: no change to test results.

@circt-bot
Copy link
Copy Markdown

circt-bot Bot commented May 15, 2026

Results of circt-tests run for 444f21b compared to results for 63fe07a: no change to test results.

@nanjo712
Copy link
Copy Markdown
Contributor Author

Gentle ping on this PR. The change on GetFileOp has been completed, so I think we can continue with this PR now. Please let me know if there’s anything else I should address.

@nanjo712
Copy link
Copy Markdown
Contributor Author

Hi @uenoku, since you have reviewed related LowerToHW changes before, would you mind taking a look when you have time? I’d mainly like to confirm whether this direction for lowering firrtl.fprintf into the core/sim path looks reasonable.

Comment thread lib/Conversion/FIRRTLToHW/LowerToHW.cpp Outdated
@nanjo712 nanjo712 force-pushed the feat/lower-firrtl-fprint-to-sim branch from 444f21b to 2a25f87 Compare May 25, 2026 05:21
@circt-bot
Copy link
Copy Markdown

circt-bot Bot commented May 25, 2026

Results of circt-tests run for 2a25f87 compared to results for 63880ae: no change to test results.

@uenoku uenoku merged commit c41754d into llvm:main May 25, 2026
6 checks passed
@nanjo712 nanjo712 deleted the feat/lower-firrtl-fprint-to-sim branch May 25, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants