[FIRRTLToHW] Lower FIRRTL prints to Sim and migrate SV lowering logic to SimToSV#10140
Closed
nanjo712 wants to merge 1 commit into
Closed
[FIRRTLToHW] Lower FIRRTL prints to Sim and migrate SV lowering logic to SimToSV#10140nanjo712 wants to merge 1 commit into
nanjo712 wants to merge 1 commit into
Conversation
Member
|
@prithayan: Are there any implications for our internal flows with this change? |
nanjo712
force-pushed
the
feat/lower-firrtl-print-to-sim
branch
4 times, most recently
from
1e8274a to
1eadb40
Compare
nanjo712
force-pushed
the
feat/lower-firrtl-print-to-sim
branch
from
1eadb40 to
035ccca
Compare
uenoku
reviewed
Apr 6, 2026
Contributor
Thanks @seldridge for pointing it out. We lower them from FIRRTL dialect to our internal representation, before LowerToHW. So this should not affect them. |
uenoku
reviewed
Apr 6, 2026
uenoku
reviewed
Apr 6, 2026
uenoku
reviewed
Apr 6, 2026
Member
There was a problem hiding this comment.
Thank you, I think this PR is good demonstration for the end-2-end change, but could you to split the PR?
As for sim.print/fflush transition, we want to keep emitting them in the same always block and preserve the relative order (so print -> fflush is called in the same cycle), and we don't have a good way to enforce that yet.
Contributor
Author
|
Thanks for feedback, I will split the PR and fix the issue. |
This was referenced Apr 7, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of #10131 .
It focuses on the migration of firrtl.printf/ firrtl.fprintf / firrtl.fflush lowering logic and introduce some change in Sim Dialect.
This is a preliminary plan I've proposed based on the current situation. Please point out any errors.