-
Notifications
You must be signed in to change notification settings - Fork 7
refactor(api-proxy): runner as pure nginx config, client streams raw bytes #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
727e789
refactor(api-proxy): runner as pure nginx config, client streams raw …
rickstaa 23b4974
fix(api-proxy): pin the proxied method and drop caller query args
rickstaa 876e5f4
docs(api-proxy): note why the client streams the image back
rickstaa 73679f8
refactor(api-proxy): name the app id after the pinned model
rickstaa 4457572
fix(api-proxy): pin the upstream Accept header
rickstaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # The whole runner: a stock nginx forwards each call to one pinned Hugging Face | ||
| # model URL and injects the operator's token. The orchestrator health-polls | ||
| # /health and reverse-proxies caller requests to /proxy. HF_TOKEN and MODEL are | ||
| # substituted from the environment by the nginx image's template mechanism. | ||
| server { | ||
| listen 8989; | ||
|
|
||
| location = /health { | ||
| default_type application/json; | ||
| return 200 '{"status":"ok"}'; | ||
| } | ||
|
|
||
| # The pinned URL is the security model: the operator's credential can only | ||
| # be spent on exactly this model, callers choose nothing but the payload. | ||
| # Method and query string are part of "nothing": nginx would forward both | ||
| # upstream as the caller sent them, so pin the method and drop the args. | ||
| location = /proxy { | ||
| limit_except POST { deny all; } | ||
| set $args ''; | ||
| proxy_pass https://router.huggingface.co/hf-inference/models/${MODEL}; | ||
| proxy_set_header Authorization "Bearer ${HF_TOKEN}"; | ||
| proxy_ssl_server_name on; | ||
| proxy_read_timeout 120s; # a hosted diffusion model can take tens of seconds | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.