Skip to content

refactor(vllm): take the HF token as HF_TOKEN in .env - #43

Merged
rickstaa merged 1 commit into
mainfrom
rs/vllm-hf-token
Jul 29, 2026
Merged

refactor(vllm): take the HF token as HF_TOKEN in .env#43
rickstaa merged 1 commit into
mainfrom
rs/vllm-hf-token

Conversation

@rickstaa

@rickstaa rickstaa commented Jul 29, 2026

Copy link
Copy Markdown
Member

Standardizes the user-facing Hugging Face token variable on HF_TOKEN — the canonical modern name (HUGGING_FACE_HUB_TOKEN was deprecated by huggingface_hub in 2023) and the same name the api-proxy example (#41) uses, so both examples read one variable from .env.

The container-side name is unchanged: compose maps HUGGING_FACE_HUB_TOKEN=${HF_TOKEN:-}, since that is the variable the stock vLLM image reads. The token stays optional (:- empty default) — only gated models need it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 29, 2026 14:55
@rickstaa
rickstaa merged commit 68a9894 into main Jul 29, 2026
2 checks passed
@rickstaa
rickstaa deleted the rs/vllm-hf-token branch July 29, 2026 14:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Standardizes the user-facing Hugging Face token environment variable for the vllm example to HF_TOKEN, while keeping the container-facing variable as HUGGING_FACE_HUB_TOKEN (as expected by the vLLM image). This aligns the vllm example with the token naming used elsewhere (e.g., api-proxy) and keeps the token optional.

Changes:

  • Update vllm/compose.yml to map HUGGING_FACE_HUB_TOKEN from ${HF_TOKEN:-}.
  • Update vllm/.env.example to document HF_TOKEN instead of HUGGING_FACE_HUB_TOKEN.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
vllm/compose.yml Maps container env HUGGING_FACE_HUB_TOKEN from the standardized user env HF_TOKEN with an empty default.
vllm/.env.example Renames the documented token variable to HF_TOKEN to match the new user-facing convention.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants