refactor(vllm): take the HF token as HF_TOKEN in .env - #43
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Standardizes the user-facing Hugging Face token environment variable for the vllm example to HF_TOKEN, while keeping the container-facing variable as HUGGING_FACE_HUB_TOKEN (as expected by the vLLM image). This aligns the vllm example with the token naming used elsewhere (e.g., api-proxy) and keeps the token optional.
Changes:
- Update
vllm/compose.ymlto mapHUGGING_FACE_HUB_TOKENfrom${HF_TOKEN:-}. - Update
vllm/.env.exampleto documentHF_TOKENinstead ofHUGGING_FACE_HUB_TOKEN.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vllm/compose.yml | Maps container env HUGGING_FACE_HUB_TOKEN from the standardized user env HF_TOKEN with an empty default. |
| vllm/.env.example | Renames the documented token variable to HF_TOKEN to match the new user-facing convention. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes the user-facing Hugging Face token variable on
HF_TOKEN— the canonical modern name (HUGGING_FACE_HUB_TOKENwas deprecated by huggingface_hub in 2023) and the same name theapi-proxyexample (#41) uses, so both examples read one variable from.env.The container-side name is unchanged: compose maps
HUGGING_FACE_HUB_TOKEN=${HF_TOKEN:-}, since that is the variable the stock vLLM image reads. The token stays optional (:-empty default) — only gated models need it.