Skip to content

Stage 1: Add GetAwaiter to YieldInstruction + StreamYieldInstruction #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MaxHeimbrock wants to merge 1 commit into
base: main
Choose a base branch
from

Add GetAwaiter to YieldInstruction and StreamYieldInstruction

da5555c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Stage 1: Add GetAwaiter to YieldInstruction + StreamYieldInstruction #289

Add GetAwaiter to YieldInstruction and StreamYieldInstruction
da5555c
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (2023.2.20f1) completed May 21, 2026 in 0s

❌️ Test Results (2023.2.20f1) - 122/129, skipped: 6, failed: 1 - Failed in 66.598s

⚠️ editmode-results.xml - 70/72, skipped: 2 - Passed in 0.509s

❌️ playmode-results.xml - 52/57, skipped: 4, failed: 1 - Failed in 66.090s

Details

⚠️ editmode-results.xml - 70/72, skipped: 2 - Passed in 0.509s
  • ✅ LiveKit.EditModeTests.DataStreamTests - 4/4 - Passed in 0.087s
    • ✅ OnChunk_ConcurrentProducerAndConsumer_AllChunksObservedInOrder - Passed in 0.060s
    • ✅ OnChunk_MultipleChunksBeforeConsumerDrains_AllChunksAreObserved - Passed in 0.002s
    • ✅ OnChunk_RacingWithReset_NoChunkLost - Passed in 0.013s
    • ✅ OnEos_RacingWithChunks_FinalStateConsistent - Passed in 0.012s
  • ✅ LiveKit.EditModeTests.DataTrackTests - 6/6 - Passed in 0.011s
    • ✅ DataTrackFrame_Constructor_WithExplicitTimestamp_SetsValue - Passed in 0.001s
    • ✅ DataTrackFrame_DurationSinceTimestamp_NullWithoutTimestamp - Passed in 0.001s
    • ✅ DataTrackFrame_DurationSinceTimestamp_ReturnsValue - Passed in 0.008s
    • ✅ DataTrackFrame_WithUserTimestampNow_DoesNotMutateOriginal - Passed in 0.001s
    • ✅ DataTrackFrame_WithUserTimestampNow_OverwritesExistingTimestamp - Passed in 0.000s
    • ✅ DataTrackFrame_WithUserTimestampNow_SetsTimestamp - Passed in 0.000s
  • ✅ LiveKit.EditModeTests.FfiHandleTests.IsInvalid_ReturnsTrueForKnownInvalidPointers - 2/2 - Passed in 0.001s
    • ✅ IsInvalid_ReturnsTrueForKnownInvalidPointers(0) - Passed in 0.001s
    • ✅ IsInvalid_ReturnsTrueForKnownInvalidPointers(-1) - Passed in 0.000s
  • ✅ LiveKit.EditModeTests.FfiResponseEnsureCleanTests.EnsureClean_Throws_ForOneofCases - 5/5 - Passed in 0.004s
    • ✅ EnsureClean_Throws_ForOneofCases("LocalTrackMute",LiveKit.Proto.LocalTrackMuteResponse) - Passed in 0.002s
    • ✅ EnsureClean_Throws_ForOneofCases("ByteStreamOpen",LiveKit.Proto.ByteStreamOpenResponse) - Passed in 0.001s
    • ✅ EnsureClean_Throws_ForOneofCases("SendStreamHeader",LiveKit.Proto.SendStreamHeaderResponse) - Passed in 0.001s
    • ✅ EnsureClean_Throws_ForOneofCases("SetRemoteTrackPublicationQuality",LiveKit.Proto.SetRemoteTrackPublicationQualityResponse) - Passed in 0.001s
    • ✅ EnsureClean_Throws_ForOneofCases("SendChatMessage",LiveKit.Proto.SendChatMessageResponse) - Passed in 0.001s
  • ✅ LiveKit.EditModeTests.FfiResponseEnsureCleanTests - 2/2 - Passed in 0.004s
    • ✅ EnsureClean_DoesNotThrow_WhenMessageCaseIsNone - Passed in 0.002s
    • ✅ EnsureClean_Throws_ForConnect - Passed in 0.002s
  • ✅ LiveKit.EditModeTests.MediaStreamLifetimeTests - 5/5 - Passed in 0.233s
    • ✅ AudioResampler_IsDisposable_AndReleasesNativeHandle - Passed in 0.057s
    • ✅ AudioStream_AudioFrames_AreDisposedAfterProcessing - Passed in 0.046s
    • ✅ AudioStream_Dispose_UnsubscribesAndReleasesOwnedResources - Passed in 0.046s
    • ✅ VideoStream_Dispose_UnsubscribesAndReleasesOwnedResources - Passed in 0.043s
    • ✅ VideoStream_UsesLatestFrameWinsCoalescing - Passed in 0.041s
  • ✅ LiveKit.EditModeTests.RingBufferTests - 16/16 - Passed in 0.008s
    • ✅ AvailableRead_AfterWrite_MatchesWrittenLength - Passed in 0.002s
    • ✅ AvailableReadInPercent_ReturnsCorrectRatio - Passed in 0.001s
    • ✅ AvailableWrite_AfterWrite_ReducedByWrittenLength - Passed in 0.000s
    • ✅ AvailableWriteInPercent_ReturnsCorrectRatio - Passed in 0.000s
    • ✅ Capacity_MatchesConstructorArgument - Passed in 0.000s
    • ✅ Clear_ResetsState - Passed in 0.000s
    • ✅ MultipleWriteReadCycles_MaintainIntegrity - Passed in 0.001s
    • ✅ Read_ReturnsNumberOfBytesRead - Passed in 0.000s
    • ✅ Read_WhenEmpty_ReturnsZero - Passed in 0.000s
    • ✅ SkipRead_AdvancesReadPosition - Passed in 0.000s
    • ✅ SkipRead_BeyondAvailable_ClampedToAvailable - Passed in 0.000s
    • ✅ Write_ReturnsNumberOfBytesWritten - Passed in 0.000s
    • ✅ Write_WhenFull_ReturnsZero - Passed in 0.000s
    • ✅ Write_WhenPartiallyFull_WritesOnlyAvailable - Passed in 0.000s
    • ✅ WriteAndRead_DataMatchesInput - Passed in 0.000s
    • ✅ WriteAndRead_WithWraparound_DataIntegrity - Passed in 0.000s
  • ✅ LiveKit.EditModeTests.RoomDisconnectTests - 2/2 - Passed in 0.001s
    • ✅ Disconnect_OnNeverConnectedRoom_CalledTwice_DoesNotThrow - Passed in 0.001s
    • ✅ Disconnect_OnNeverConnectedRoom_DoesNotThrow - Passed in 0.000s
  • ✅ LiveKit.EditModeTests.RoomStreamHandlerTests - 4/4 - Passed in 0.003s
    • ✅ RegisterByteStreamHandler_DuplicateTopic_ThrowsStreamError - Passed in 0.001s
    • ✅ RegisterTextStreamHandler_DuplicateTopic_ThrowsStreamError - Passed in 0.001s
    • ✅ UnregisterByteStreamHandler_AllowsReregistrationOfSameTopic - Passed in 0.000s
    • ✅ UnregisterTextStreamHandler_AllowsReregistrationOfSameTopic - Passed in 0.000s
  • ✅ LiveKit.EditModeTests.RpcErrorTests - 4/4 - Passed in 0.005s
    • ✅ BuiltIn_HasMessageAndCodeForEveryErrorCode - Passed in 0.004s
    • ✅ Constructor_DefaultDataIsNull - Passed in 0.000s
    • ✅ Constructor_SetsCodeMessageAndData - Passed in 0.000s
    • ✅ RpcError_IsException - Passed in 0.000s
  • ✅ LiveKit.EditModeTests.SkipDispatchTests - 5/5 - Passed in 0.016s
    • ✅ InlineCallback_RunsOnDispatchingBackgroundThread - Passed in 0.008s
    • ✅ MainThreadCallback_TrySkipDispatch_ReturnsFalseAndDoesNotComplete - Passed in 0.001s
    • ✅ RouteFfiEvent_InlineCallback_CompletesOnDispatchingThread - Passed in 0.002s
    • ✅ RouteFfiEvent_MainThreadCallback_PostsToSynchronizationContext_AndDrainsCompletion - Passed in 0.003s
    • ✅ TryDispatchPendingCallback_RunsCompletionSynchronouslyOnCallerThread - Passed in 0.001s
  • ✅ LiveKit.EditModeTests.ThreadSafeQueueTests - 5/5 - Passed in 0.007s
    • ✅ Clear_SetsCountToZero - Passed in 0.001s
    • ✅ ConcurrentEnqueueDequeue_NoExceptions - Passed in 0.004s
    • ✅ Dequeue_ReturnsEnqueuedItem_FIFO - Passed in 0.001s
    • ✅ Dequeue_WhenEmpty_ThrowsInvalidOperationException - Passed in 0.001s
    • ✅ Enqueue_IncreasesCount - Passed in 0.000s
  • ⚠️ LiveKit.EditModeTests.UsageStrictTests.NoManualCreateNew - 0/2, skipped: 2 - Passed in 0.000s
    • ⚠️ NoManualCreateNew("FfiResponse") - Skipped
    • ⚠️ NoManualCreateNew("FfiRequest") - Skipped
  • ✅ LiveKit.EditModeTests.VideoFrameTests.Create_ReturnsCorrectConcreteType - 6/6 - Passed in 0.009s
    • ✅ Create_ReturnsCorrectConcreteType(I420,LiveKit.I420Buffer) - Passed in 0.007s
    • ✅ Create_ReturnsCorrectConcreteType(I420A,LiveKit.I420ABuffer) - Passed in 0.000s
    • ✅ Create_ReturnsCorrectConcreteType(I422,LiveKit.I422Buffer) - Passed in 0.000s
    • ✅ Create_ReturnsCorrectConcreteType(I444,LiveKit.I444Buffer) - Passed in 0.000s
    • ✅ Create_ReturnsCorrectConcreteType(I010,LiveKit.I010Buffer) - Passed in 0.000s
    • ✅ Create_ReturnsCorrectConcreteType(Nv12,LiveKit.NV12Buffer) - Passed in 0.000s
  • ✅ LiveKit.EditModeTests.VideoFrameTests - 1/1 - Passed in 0.000s
    • ✅ Create_ReturnsNull_ForUnsupportedType - Passed in 0.000s
  • ✅ LiveKit.EditModeTests.YieldInstructionThreadingTests - 3/3 - Passed in 0.032s
    • ✅ IsDone_SetFromBackgroundThread_ObservedByForegroundSpin - Passed in 0.008s
    • ✅ IsError_VisibleAcrossThreadsOnceIsDoneIsObserved - Passed in 0.003s
    • ✅ KeepWaiting_FlipsToFalse_AfterBackgroundCompletion - Passed in 0.021s
❌️ playmode-results.xml - 52/57, skipped: 4, failed: 1 - Failed in 66.090s
  • ❌️ LiveKit.PlayModeTests.AudioBufferTests - 2/3, failed: 1 - Failed in 5.838s

    • ❌️ AudioBuffer_FillLevelStaysStable - Failed in 2.734s
      Expected: null
      But was: "Expectation timed out (1s)"

        NewAudioSource: 2 48000

at LiveKit.PlayModeTests.AudioBufferTests+<AudioBuffer_FillLevelStaysStable>d__7.MoveNext () [0x00097] in root/Tests/PlayMode/AudioBufferTests.cs:110
at UnityEngine.TestTools.TestEnumerator+<Execute>d__7.MoveNext () [0x0004e] in ./Library/PackageCache/com.unity.test-framework@1.3.9/UnityEngine.TestRunner/NUnitExtensions/Attributes/TestEnumerator.cs:44

    • ✅ AudioBuffer_WhenAppForegrounded_BufferIsCleared - Passed in 1.577s

    • ✅ AudioBuffer_WhenBufferRunsFull_TriggersCatchupMechanism - Passed in 1.526s

  • ✅ LiveKit.PlayModeTests.ByteStreamTests - 1/1 - Passed in 1.396s
    • ✅ StreamBytes_WriteAndClose_ReceivedViaReadAll - Passed in 1.396s
  • ✅ LiveKit.PlayModeTests.DataStreamTests - 5/5 - Passed in 0.008s
    • ✅ RegisterByteHandler_FailsWithDuplicateTopic - Passed in 0.005s
    • ✅ RegisterTextAndByteHandler_SameTopic_BothSucceed - Passed in 0.001s
    • ✅ RegisterTextHandler_FailsWithDuplicateTopic - Passed in 0.000s
    • ✅ UnregisterByteHandler_ThenRegisterSameTopic_Succeeds - Passed in 0.001s
    • ✅ UnregisterTextHandler_ThenRegisterSameTopic_Succeeds - Passed in 0.000s
  • ✅ LiveKit.PlayModeTests.DataTrackTests - 9/9 - Passed in 13.122s
    • ✅ PublishAndUnpublish_TriggersEvents - Passed in 2.351s
    • ✅ PublishDataTrack_IsPublishedReturnsTrue - Passed in 1.102s
    • ✅ PublishDataTrack_Succeeds - Passed in 1.166s
    • ✅ PublishDataTrack_TrackInfoMatchesOptions - Passed in 1.153s
    • ✅ PushAndReceive_FramePayloadMatches - Passed in 2.276s
    • ✅ PushAndReceive_TimestampIsPreserved - Passed in 1.427s
    • ✅ Subscribe_Succeeds - Passed in 1.393s
    • ✅ TryPush_Succeeds - Passed in 1.153s
    • ✅ Unpublish_IsPublishedReturnsFalse - Passed in 1.099s
  • ✅ LiveKit.PlayModeTests.FfiBoundaryTests - 1/1 - Passed in 1.135s
    • ✅ Disconnect_CalledTwice_DoesNotThrow - Passed in 1.135s
  • ✅ LiveKit.PlayModeTests.FfiHandleDisposalTests - 1/1 - Passed in 1.283s
    • ✅ StreamWriter_LeakedHandle_DoesNotCrashOnGC - Passed in 1.283s
  • ✅ LiveKit.PlayModeTests.LocalParticipantTests - 4/4 - Passed in 2.435s
    • ✅ Identity_MatchesProvided - Passed in 0.118s
    • ✅ Metadata_MatchesProvided - Passed in 0.157s
    • ✅ Name_MatchesProvided - Passed in 1.079s
    • ✅ Sid_StartsWithPA - Passed in 1.081s
  • ✅ LiveKit.PlayModeTests.ParticipantMetadataTests - 3/3 - Passed in 5.834s
    • ✅ SetAttributes_UpdatesLocalAndTriggersRemoteEvent - Passed in 2.244s
    • ✅ SetMetadata_UpdatesLocalAndTriggersRemoteEvent - Passed in 2.299s
    • ✅ SetName_UpdatesLocalAndTriggersRemoteEvent - Passed in 1.291s
  • ⚠️ LiveKit.PlayModeTests.RoomTests - 5/9, skipped: 4 - Passed in 4.330s
    • ✅ Connect_FailsWithInvalidUrl - Passed in 0.003s
    • ✅ Connect_FailsWithInvalidUrl_Awaitable - Passed in 0.003s
    • ⚠️ ConnectionState_IsConnected - Skipped
    • ⚠️ Disconnect_TriggersEvent - Skipped
    • ⚠️ ParticipantDisconnect_TriggersEvent - Skipped
    • ✅ ParticipantJoin_CreatesRemoteParticipant - Passed in 3.059s
    • ⚠️ ParticipantJoin_TriggersEvent - Skipped
    • ✅ RoomName_MatchesProvided - Passed in 0.170s
    • ✅ RoomSid_StartsWithRM - Passed in 1.094s
  • ✅ LiveKit.PlayModeTests.RpcTests - 7/7 - Passed in 11.988s
    • ✅ RegisterRpcMethod_AndPerformRpc_ReturnsResponse - Passed in 2.248s
    • ✅ PerformRpc_NearLimitPayload_EchoesRoundTrip - Passed in 2.262s
    • ✅ PerformRpc_ConcurrentInvocations_AllComplete - Passed in 1.345s
    • ✅ PerformRpc_HandlerThrowsGenericException_ReturnsApplicationError - Passed in 1.274s
    • ✅ PerformRpc_HandlerThrowsRpcError_PropagatesError - Passed in 2.301s
    • ✅ PerformRpc_UnregisteredMethod_ReturnsUnsupportedMethod - Passed in 1.286s
    • ✅ UnregisterRpcMethod_ThenPerformRpc_ReturnsUnsupportedMethod - Passed in 1.273s
  • ✅ LiveKit.PlayModeTests.StreamLifecycleTests - 1/1 - Passed in 1.266s
    • ✅ SendFile_RecipientReceivesBytes - Passed in 1.266s
  • ✅ LiveKit.PlayModeTests.TextStreamTests - 4/4 - Passed in 6.588s
    • ✅ SendText_ReceivedByHandler_ContentMatches - Passed in 0.563s
    • ✅ SendText_WithTopic_DispatchesToCorrectHandler - Passed in 2.280s
    • ✅ StreamText_CloseWithoutReason_Succeeds - Passed in 2.276s
    • ✅ StreamText_WriteAndClose_ReceivedViaReadAll - Passed in 1.469s
  • ✅ LiveKit.PlayModeTests.TrackTests - 8/8 - Passed in 10.213s
    • ✅ LocalAudioTrack_SetMute_TrueFalse_TogglesSourceMuteState - Passed in 0.259s
    • ✅ PublishAudioTrack_UnpublishAndRepublish_Succeeds - Passed in 1.214s
    • ✅ RemoteTrack_GetStats_ReturnsNoError - Passed in 2.888s
    • ✅ RemoteTrack_SetEnabled_FalseAndTrue_DoesNotThrow - Passed in 1.302s
    • ✅ RemoteTrackPublication_PublisherDisablesCamera_UpdatesFlagAndTriggersEvent - Passed in 1.291s
    • ✅ RemoteTrackPublication_PublisherMutesMic_UpdatesFlagAndTriggersEvent - Passed in 1.351s
    • ✅ RemoteTrackPublication_SetVideoQuality_DoesNotThrow - Passed in 0.478s
    • ✅ RemoteTrackPublication_Unsubscribe_UpdatesFlagAndTriggersEvent - Passed in 1.431s
  • ✅ LiveKit.PlayModeTests.VideoFrameMetadataTests - 1/1 - Passed in 0.519s
    • ✅ VideoFrame_AttachedMetadata_ReceivedOnSubscriber - Passed in 0.519s

Annotations

Check failure on line 110 in root/Tests/PlayMode/AudioBufferTests.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (2023.2.20f1)

LiveKit.PlayModeTests.AudioBufferTests.AudioBuffer_FillLevelStaysStable 

  Expected: null
  But was:  "Expectation timed out (1s)"
Raw output 
NewAudioSource: 2 48000

at LiveKit.PlayModeTests.AudioBufferTests+<AudioBuffer_FillLevelStaysStable>d__7.MoveNext () [0x00097] in /github/workspace/root/Tests/PlayMode/AudioBufferTests.cs:110
at UnityEngine.TestTools.TestEnumerator+<Execute>d__7.MoveNext () [0x0004e] in ./Library/PackageCache/com.unity.test-framework@1.3.9/UnityEngine.TestRunner/NUnitExtensions/Attributes/TestEnumerator.cs:44
View more details on GitHub Actions