Skip to content

Code Scan Fix: Remove redundant AsyncId checks from instruction callbacks #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MaxHeimbrock wants to merge 1 commit into
base: main
Choose a base branch
from

Remove redundant AsyncId checks from instruction callbacks

34ce64a
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Code Scan Fix: Remove redundant AsyncId checks from instruction callbacks #232

Remove redundant AsyncId checks from instruction callbacks
34ce64a
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (2023.2.20f1) completed Apr 10, 2026 in 0s

⚠️ Test Results (2023.2.20f1) - 26/33, skipped: 7 - Passed in 18.691s

⚠️ editmode-results.xml - 5/7, skipped: 2 - Passed in 0.254s

⚠️ playmode-results.xml - 21/26, skipped: 5 - Passed in 18.436s

Details

⚠️ editmode-results.xml - 5/7, skipped: 2 - Passed in 0.254s
  • ✅ LiveKit.EditModeTests.MediaStreamLifetimeTests - 5/5 - Passed in 0.218s
    • ✅ AudioResampler_IsDisposable_AndReleasesNativeHandle - Passed in 0.064s
    • ✅ AudioStream_AudioFrames_AreDisposedAfterProcessing - Passed in 0.039s
    • ✅ AudioStream_Dispose_UnsubscribesAndReleasesOwnedResources - Passed in 0.039s
    • ✅ VideoStream_Dispose_UnsubscribesAndReleasesOwnedResources - Passed in 0.038s
    • ✅ VideoStream_UsesLatestFrameWinsCoalescing - Passed in 0.038s
  • ⚠️ LiveKit.EditModeTests.UsageStrictTests.NoManualCreateNew - 0/2, skipped: 2 - Passed in 0.000s
    • ⚠️ NoManualCreateNew("FfiResponse") - Skipped
    • ⚠️ NoManualCreateNew("FfiRequest") - Skipped
⚠️ playmode-results.xml - 21/26, skipped: 5 - Passed in 18.436s
  • ✅ LiveKit.PlayModeTests.DataStreamTests - 2/2 - Passed in 0.029s
    • ✅ RegisterByteHandler_FailsWithDuplicateTopic - Passed in 0.028s
    • ✅ RegisterTextHandler_FailsWithDuplicateTopic - Passed in 0.001s
  • ✅ LiveKit.PlayModeTests.DataTrackTests - 12/12 - Passed in 9.649s
    • ✅ DataTrackFrame_DurationSinceTimestamp_NullWithoutTimestamp - Passed in 0.002s
    • ✅ DataTrackFrame_DurationSinceTimestamp_ReturnsValue - Passed in 0.009s
    • ✅ DataTrackFrame_WithUserTimestampNow_SetsTimestamp - Passed in 0.004s
    • ✅ PublishAndUnpublish_TriggersEvents - Passed in 0.587s
    • ✅ PublishDataTrack_IsPublishedReturnsTrue - Passed in 0.119s
    • ✅ PublishDataTrack_Succeeds - Passed in 0.113s
    • ✅ PublishDataTrack_TrackInfoMatchesOptions - Passed in 1.241s
    • ✅ PushAndReceive_FramePayloadMatches - Passed in 1.420s
    • ✅ PushAndReceive_TimestampIsPreserved - Passed in 1.304s
    • ✅ Subscribe_Succeeds - Passed in 2.422s
    • ✅ TryPush_Succeeds - Passed in 1.290s
    • ✅ Unpublish_IsPublishedReturnsFalse - Passed in 1.135s
  • ✅ LiveKit.PlayModeTests.LocalParticipantTests - 4/4 - Passed in 2.592s
    • ✅ Identity_MatchesProvided - Passed in 1.194s
    • ✅ Metadata_MatchesProvided - Passed in 0.106s
    • ✅ Name_MatchesProvided - Passed in 0.106s
    • ✅ Sid_StartsWithPA - Passed in 1.186s
  • ⚠️ LiveKit.PlayModeTests.RoomTests - 3/8, skipped: 5 - Passed in 6.117s
    • ✅ Connect_FailsWithInvalidUrl - Passed in 0.002s
    • ⚠️ ConnectionState_IsConnected - Skipped
    • ⚠️ Disconnect_TriggersEvent - Skipped
    • ⚠️ ParticipantDisconnect_TriggersEvent - Skipped
    • ✅ ParticipantJoin_CreatesRemoteParticipant - Passed in 3.057s
    • ✅ ParticipantJoin_TriggersEvent - Passed in 3.057s
    • ⚠️ RoomName_MatchesProvided - Skipped
    • ⚠️ RoomSid_StartsWithRM - Skipped
View more details on GitHub Actions