fix/preserve-stt-eos-timestamp-for-metrics#5755
Open
dhruvladia-sarvam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
turn_handling.turn_detection = "stt"is used with an STT plugin that emitsSpeechEventType.END_OF_SPEECH(e.g. Sarvam, AssemblyAI) and no external VAD,EOUMetrics.transcription_delayandEOUMetrics.end_of_utterance_delayare always reported as0.0.Root cause
AudioRecognition._on_stt_eventunconditionally overwritesself._last_speaking_timewithtime.time()whenever aFINAL_TRANSCRIPT(orPREFLIGHT_TRANSCRIPT) arrives andself._vad is None— even though the STT plugin already populated that field with the actual end-of-speech moment viaEND_OF_SPEECH. The framework's own TODO comment acknowledged this:Fix
Skip the overwrite when
turn_detection_mode == "stt", since in that mode the STT plugin is the authoritative source of speech boundaries.Behavior matrix
turn_detection"vad"/"manual""stt"