Skip to content

feat: support python -m livekit.agents.download for asset fetching#5738

Merged
davidzhao merged 4 commits into
mainfrom
dz/optimize-download
May 16, 2026
Merged

feat: support python -m livekit.agents.download for asset fetching#5738
davidzhao merged 4 commits into
mainfrom
dz/optimize-download

Conversation

@davidzhao
Copy link
Copy Markdown
Member

enables more efficient docker images by installing plugin layer before application code gets copied over

enables more efficient docker images by installing plugin layer before
application code gets copied over
@davidzhao davidzhao requested review from a team, real-danm and yoonsio May 14, 2026 15:57
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@real-danm real-danm requested a review from andrewnitu May 14, 2026 18:32
Copy link
Copy Markdown
Contributor

@real-danm real-danm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but a bit of a rubber stamp, i'm not aware of any downstream effect this will have.

Copy link
Copy Markdown
Contributor

@longcw longcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! somehting nit:

# c.print(f"Importing from {import_data.module_data.extra_sys_path}")
# c.print(" ")
c.print(
"[yellow]`download-files` via the agent CLI is deprecated. "
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the message in

"Use `python3 your_agent.py download-files` to download the models."
as well?

Copy link
Copy Markdown
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a generic CLI script instead?

You can add a __main__.py inside livekit/agents

Then maybe it can becomes python3 -m livekit.agents download-files

So it can be reused for more stuff in the future

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@davidzhao davidzhao merged commit 75e4a37 into main May 16, 2026
27 checks passed
@davidzhao davidzhao deleted the dz/optimize-download branch May 16, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants