Skip to content

fix: handle LinkNotFound errors on geneve interface list#3232

Merged
adamjensenbot merged 1 commit intoliqotech:masterfrom
fra98:frt/restart-worker-node
Apr 28, 2026
Merged

fix: handle LinkNotFound errors on geneve interface list#3232
adamjensenbot merged 1 commit intoliqotech:masterfrom
fra98:frt/restart-worker-node

Conversation

@fra98
Copy link
Copy Markdown
Member

@fra98 fra98 commented Mar 24, 2026

Description

This PR modifies the ExistGeneveInterface() function to handle LinkNotFound errors from generic errors.
In this way we can distinguish between the two cases and avoid unnecessary deletion and recreation of geneve tunnels in case we get a generic error when listing existing interfaces. In such case, reconcile will return with error, therefore will be retried.

@adamjensenbot
Copy link
Copy Markdown
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions Bot added the fix Fixes a bug in the codebase. label Mar 24, 2026
@cheina97
Copy link
Copy Markdown
Member

/rebase test=true

1 similar comment
@fra98
Copy link
Copy Markdown
Member Author

fra98 commented Apr 28, 2026

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frt/restart-worker-node branch from e287623 to dee34ae Compare April 28, 2026 13:28
@fra98
Copy link
Copy Markdown
Member Author

fra98 commented Apr 28, 2026

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Apr 28, 2026
@adamjensenbot adamjensenbot merged commit 1fc3eb9 into liqotech:master Apr 28, 2026
19 of 20 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes a bug in the codebase. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants