feat: display repo license info IN-1099#1906
Merged
Merged
Conversation
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds repository license information to the project detail flow, mapping Tinybird license tuples into repository data and rendering license chips in the project about section.
Changes:
- Extends project/repository types with license data.
- Maps
repoLicensesfrom Tinybird onto each repository in the project API. - Adds and mounts a new licenses UI component with chips, tooltips/popovers, and show more/less behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
frontend/types/project.ts |
Adds license-related fields to project repository and Tinybird types. |
frontend/server/api/project/[slug]/index.ts |
Builds a license lookup and attaches license arrays to returned repositories. |
frontend/app/components/modules/project/components/overview/about-section/licenses.vue |
New UI for displaying project/repository licenses and repo-filter popovers. |
frontend/app/components/modules/project/components/overview/about-section.vue |
Mounts the licenses component in the project about section. |
Comments suppressed due to low confidence (1)
frontend/app/components/modules/project/components/overview/about-section/licenses.vue:66
- These repository options are clickable
<div>elements without keyboard semantics. Even when the popover is open, they are not focusable and do not expose button/listbox behavior to assistive technologies; render them as buttons/links or add the necessary role, tabindex, and key handlers.
<div
v-for="repo of getReposForLicense(license)"
:key="repo.url"
class="flex items-center pl-2 py-2 gap-3 w-full rounded-lg cursor-pointer hover:bg-neutral-50"
@click="filterByRepo(repo.slug)"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+110
to
+112
| const isRepoSelected = computed(() => selectedRepositories.value.length > 0); | ||
|
|
||
| const activeRepos = computed(() => (isRepoSelected.value ? selectedRepositories.value : projectRepos.value)); |
| slug, | ||
| score: details.score || 0, | ||
| rank: details.rank || 0, | ||
| licenses: licensesByUrl[repoUrl] || [], |
joanagmaia
requested changes
May 14, 2026
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repoLicensestuples from Tinybird into per-repositorylicensesarrays in the project API endpointLfxProjectLicensescomponent to the project about section displaying license chips with tooltip/popover interactionsNONElicenses, displayNOASSERTIONas "Other", sort "Other" lastnormalizeRepoName(same as repository selector)Changes
frontend/types/project.ts— addedlicenses: string[]toProjectRepository,repoLicenses: [string, string][]toProjectTinybirdfrontend/server/api/project/[slug]/index.ts— map repo licenses from Tinybird response onto each repository objectfrontend/app/components/modules/project/components/overview/about-section/licenses.vue— new licenses display componentfrontend/app/components/modules/project/components/overview/about-section.vue— mount<lfx-licenses />in the about section