ci: declare contents:read on license + yarn-audit workflows#5054
Open
arpitjain099 wants to merge 1 commit into
Open
ci: declare contents:read on license + yarn-audit workflows#5054arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
License-header-check runs ./check-headers.sh against the cla-backend trees. The two yarn-scan workflows run yarn install + yarn audit on cla-backend-go and cla-backend after checkout. No GitHub API write, no comment-on-PR. contents:read at workflow scope matches the per-job style used by build-pr.yml (id-token:write + contents:read + pull-requests:write), go-audit.yml, license-compliance-go.yml, and security-scan-go.yml. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThree GitHub Actions workflows now declare explicit permissions restricting GitHub token access to ChangesWorkflow Permissions Hardening
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins three workflows to
contents: readat workflow scope.license-header-check.ymlruns./check-headers.shagainst the cla-backend, cla-backend-legacy, cla-backend-go and cla-frontend trees. The two yarn-scan workflows runyarn install+yarn auditoncla-backend-goandcla-backendrespectively. None of them write to the repo or post comments.Defense-in-depth motivation is the CVE-2025-30066
tj-actions/changed-filesprecedent: a compromised third-party action runs inside the existing job context and exfiltrates the workflowGITHUB_TOKENvia build logs. The blast radius equals the token's issued scope; the explicit cap bounds it.Style matches the per-job blocks already in
build-pr.yml,go-audit.yml,license-compliance-go.yml,security-scan-go.yml, and the rest of the hardened set. YAML validated locally withyaml.safe_load.