Fix 5047 - prod#5051
Conversation
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes prod issues related to missing/legacy data and identity normalization to prevent noisy warnings/errors and improve user/event consistency.
Changes:
- Avoid formatting empty legacy signature timestamps to prevent spurious warnings.
- Skip event creation when UserID can’t be resolved, logging a warning instead of erroring.
- Normalize and persist user identity updates (display name + lowercased LF email) and add unit tests; avoid AWS/SSM init during
go test.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| cla-backend-go/signatures/converters.go | Guard signature date formatting when legacy timestamps are empty. |
| cla-backend-go/events/service.go | Skip logging events when UserID is unresolved to avoid error spam. |
| cla-backend-go/emails/params.go | Prevent panics on empty Projects slice in email template params helpers. |
| cla-backend-go/company/repository.go | Early-return on empty companyID to avoid bad DynamoDB lookups. |
| cla-backend-go/cmd/server.go | Refresh stored user identity (name + normalized LF email) and update callers/logging. |
| cla-backend-go/cmd/root.go | Skip ini.Init() during tests to avoid failing on missing AWS env vars. |
| cla-backend-go/cmd/refresh_stored_username_test.go | Add tests for refreshStoredUserIdentity behavior and email normalization. |
Fixes #5047 -
prod.Signed-off-by: Lukasz Gryglicki lgryglicki@cncf.io
Assisted by OpenAI
Assisted by GitHub Copilot
Assisted by Claude