Skip to content

Fix 5047 - prod#5051

Merged
lukaszgryglicki merged 1 commit into
mainfrom
unicron-5047-prod
May 14, 2026
Merged

Fix 5047 - prod#5051
lukaszgryglicki merged 1 commit into
mainfrom
unicron-5047-prod

Conversation

@lukaszgryglicki
Copy link
Copy Markdown
Member

Fixes #5047 - prod.

Signed-off-by: Lukasz Gryglicki lgryglicki@cncf.io

Assisted by OpenAI

Assisted by GitHub Copilot

Assisted by Claude

Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)
@lukaszgryglicki lukaszgryglicki self-assigned this May 13, 2026
Copilot AI review requested due to automatic review settings May 13, 2026 07:32
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 03f5d284-e555-474a-be78-2102f52a533c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch unicron-5047-prod

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes prod issues related to missing/legacy data and identity normalization to prevent noisy warnings/errors and improve user/event consistency.

Changes:

  • Avoid formatting empty legacy signature timestamps to prevent spurious warnings.
  • Skip event creation when UserID can’t be resolved, logging a warning instead of erroring.
  • Normalize and persist user identity updates (display name + lowercased LF email) and add unit tests; avoid AWS/SSM init during go test.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
cla-backend-go/signatures/converters.go Guard signature date formatting when legacy timestamps are empty.
cla-backend-go/events/service.go Skip logging events when UserID is unresolved to avoid error spam.
cla-backend-go/emails/params.go Prevent panics on empty Projects slice in email template params helpers.
cla-backend-go/company/repository.go Early-return on empty companyID to avoid bad DynamoDB lookups.
cla-backend-go/cmd/server.go Refresh stored user identity (name + normalized LF email) and update callers/logging.
cla-backend-go/cmd/root.go Skip ini.Init() during tests to avoid failing on missing AWS env vars.
cla-backend-go/cmd/refresh_stored_username_test.go Add tests for refreshStoredUserIdentity behavior and email normalization.

Comment thread cla-backend-go/events/service.go
Comment thread cla-backend-go/company/repository.go
Comment thread cla-backend-go/cmd/root.go
Comment thread cla-backend-go/cmd/root.go
Comment thread cla-backend-go/cmd/refresh_stored_username_test.go
@lukaszgryglicki lukaszgryglicki merged commit 3e9a873 into main May 14, 2026
10 of 11 checks passed
@lukaszgryglicki lukaszgryglicki deleted the unicron-5047-prod branch May 14, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants