Skip to content

fix: reduce false-positive merge suggestions from single-word display names (CM-1137) #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skwowet merged 1 commit into from
May 15, 2026
+22 −2
Merged

fix: reduce false-positive merge suggestions from single-word display names (CM-1137) #4123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion services/apps/merge_suggestions_worker/src/memberSimilarityCalculator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,18 @@ class MemberSimilarityCalculator {
if (
similarMember.keyword_displayName.toLowerCase() === primaryMember.displayName.toLowerCase()
) {
return this.decideMemberSimilarityUsingAdditionalChecks(primaryMember, similarMember)
const dn = primaryMember.displayName.toLowerCase().trim()
if (isOsReservedName(dn)) {
return this.LOW_CONFIDENCE_SCORE
}
// Single-word names (first-name-only, handles) are too ambiguous without a corroborating
// signal. Multi-word names (full names) are treated as high-confidence on their own.
const isFullName = dn.includes(' ')
return this.decideMemberSimilarityUsingAdditionalChecks(
primaryMember,
similarMember,
isFullName ? undefined : this.HIGH_CONFIDENCE_SCORE,
Comment thread
skwowet marked this conversation as resolved.
)
}

// calculate similarity percentage
Expand Down
11 changes: 10 additions & 1 deletion services/apps/merge_suggestions_worker/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,16 @@ export function stripProtocol(value: string) {

// Generic git user.name placeholders and OS account names that are never a real human
// identity — shared across unrelated machines and meaningless as a merge signal.
const OS_RESERVED_NAMES = new Set(['unknown', 'root', 'ubuntu', 'admin', 'user', 'guest'])
const OS_RESERVED_NAMES = new Set([
'unknown',
'root',
'ubuntu',
'admin',
'user',
'guest',
'[[unknown]] [not provided]',
'deleted user',
])

export function isOsReservedName(name: string): boolean {
return OS_RESERVED_NAMES.has(name.trim().toLowerCase())
Expand Down
Loading