Skip to content

feat: quality audit - edition 2024, latest deps, CI/CD best practices alignment#15

Merged
konard merged 7 commits into
mainfrom
issue-14-19a42028503e
Apr 14, 2026
Merged

feat: quality audit - edition 2024, latest deps, CI/CD best practices alignment#15
konard merged 7 commits into
mainfrom
issue-14-19a42028503e

Conversation

@konard
Copy link
Copy Markdown
Member

@konard konard commented Apr 14, 2026

Summary

Comprehensive quality audit and best practices alignment for issue #14:

  • Rust Edition 2024 with MSRV 1.85 (upgraded from edition 2018)
  • Latest stable dependencies: thiserror 2.x, quickcheck 1.1, quickcheck_macros 1.2, beef 0.5.2
  • CI/CD scripts migrated from Node.js to Rust (rust-script) matching the template at rust-ai-driven-development-pipeline-template
  • CI/CD workflow upgraded with change detection, version-check, Codecov coverage (cargo-llvm-cov), GitHub Pages docs deployment, crates.io publishing, and changelog-pr mode
  • Clippy pedantic + nursery lints enabled and all warnings resolved
  • Release profile optimization: LTO, single codegen unit, symbol stripping
  • 94 tests (up from 80) with new converter roundtrip and error variant test coverage
  • Documentation updated: fixed repository URLs, updated MSRV, added CI badge
  • Case study document at docs/case-studies/issue-14/

Changes Checklist

  • No unstable Rust features used (stable toolchain, edition 2024)
  • Latest dependency versions
  • All tests in tests/ folder (none in src/)
  • CI/CD aligned with reference repos (mem-rs, trees-rs, Numbers, template)
  • Documentation in sync with code
  • Test coverage increased (94 tests)
  • Automated documentation generation (deploy-docs job)
  • Changelog fragment added

Test plan

  • cargo fmt --all -- --check passes
  • cargo clippy --all-targets --all-features passes with zero warnings
  • cargo test --all-features passes (94 tests)
  • cargo test --doc passes
  • rust-script scripts/check-file-size.rs passes
  • CI pipeline passes on GitHub Actions

Closes #14

🤖 Generated with Claude Code

Adding .gitkeep for PR creation (default mode).
This file will be removed when the task is complete.

Issue: #14
@konard konard self-assigned this Apr 14, 2026
konard and others added 5 commits April 14, 2026 08:38
…y compliance

- Update Cargo.toml: edition 2024, rust-version 1.85, latest deps (thiserror 2.x, quickcheck 1.1, etc.)
- Add clippy lints config (pedantic + nursery) and release profile optimization
- Fix all clippy warnings (#[must_use], const fn, Self usage, doc_markdown, format args)
- Fix repository URL to point to data-rs instead of platform-rs
- Add package metadata (keywords, categories, readme)
- Add case study document for issue #14

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace Node.js (.mjs) scripts with Rust scripts (rust-script)
- Add change detection job (skip unnecessary CI for docs-only PRs)
- Add version modification check (prevent manual version changes in PRs)
- Switch from tarpaulin to cargo-llvm-cov with Codecov integration
- Add GitHub Pages documentation deployment (deploy-docs job)
- Add changelog-pr mode for manual releases
- Add crates.io publishing support
- Upgrade to actions/checkout@v6 and actions/cache@v5

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add comprehensive roundtrip tests for AddrToRaw/RawToAddr across u8, u16, u32, u64, usize
- Add tests for all Error enum variants (display, debug, From impls)
- Increases test count from 80 to 94

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix repository URLs (core-rs -> data-rs)
- Update MSRV documentation (1.79 -> 1.85)
- Add CI badge and documentation section to README
- Update CONTRIBUTING to reference rust-script instead of Node.js
- Add changelog fragment for this PR

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@konard konard changed the title [WIP] Double check we don't depend on any non stable features of rust and use all the latest best practices and versions of rust in the code feat: quality audit - edition 2024, latest deps, CI/CD best practices alignment Apr 14, 2026
@konard konard marked this pull request as ready for review April 14, 2026 08:53
@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 14, 2026

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost: $11.028873

📊 Context and tokens usage:

Claude Opus 4.6:

  • Context window: 142.7K / 1M (14%) input tokens, 67.1K / 128K (52%) output tokens

Total: (219.0K + 15.2M cached) input tokens, 67.1K output tokens, $10.626036 cost

Claude Haiku 4.5:

Total: (125.3K + 1.0M cached) input tokens, 28.5K / 64K (44%) output tokens, $0.402837 cost

🤖 Models used:

  • Tool: Anthropic Claude Code
  • Requested: opus
  • Main model: Claude Opus 4.6 (claude-opus-4-6)
  • Additional models:
    • Claude Haiku 4.5 (claude-haiku-4-5-20251001)

📎 Log file uploaded as Gist (5033KB)


Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard
Copy link
Copy Markdown
Member Author

konard commented Apr 14, 2026

✅ Ready to merge

This pull request is now ready to be merged:

  • All CI checks have passed
  • No merge conflicts
  • No pending changes

Monitored by hive-mind with --auto-restart-until-mergeable flag

@konard konard merged commit 4447ea4 into main Apr 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double check we don't depend on any non stable features of rust and use all the latest best practices and versions of rust in the code

1 participant