Skip to content

refactor: rename UsedFilesListLock to UsedFilesListLockObject #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leno23 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: rename UsedFilesListLock to UsedFilesListLockObject #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/Platform.IO/TemporaryFiles.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
class TemporaryFiles
{
private: inline static std::string UserFilesListFileNamePrefix = ".used-temporary-files.txt";
private: inline static const void *UsedFilesListLock = new();
private: inline static const void *UsedFilesListLockObject = new();
private: inline static const std::string UsedFilesListFilename = Assembly.GetExecutingAssembly().Location + UserFilesListFileNamePrefix;

private: static void AddToUsedFilesList(std::string filename)
{
lock (UsedFilesListLock)
lock (UsedFilesListLockObject)
{
FileHelpers.AppendLine(UsedFilesListFilename, filename);
}
Expand All @@ -23,7 +23,7 @@

public: static void DeleteAllPreviouslyUsed()
{
lock (UsedFilesListLock)
lock (UsedFilesListLockObject)
{
auto listFilename = UsedFilesListFilename;
if (File.Exists(listFilename))
Expand Down
6 changes: 3 additions & 3 deletions csharp/Platform.IO/TemporaryFiles.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ namespace Platform.IO
public class TemporaryFiles
{
private const string UserFilesListFileNamePrefix = ".used-temporary-files.txt";
private static readonly object UsedFilesListLock = new();
private static readonly object UsedFilesListLockObject = new();
private static readonly string UsedFilesListFilename = Assembly.GetExecutingAssembly().Location + UserFilesListFileNamePrefix;
[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static void AddToUsedFilesList(string filename)
{
lock (UsedFilesListLock)
lock (UsedFilesListLockObject)
{
FileHelpers.AppendLine(UsedFilesListFilename, filename);
}
Expand Down Expand Up @@ -45,7 +45,7 @@ public static string UseNew()
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void DeleteAllPreviouslyUsed()
{
lock (UsedFilesListLock)
lock (UsedFilesListLockObject)
{
var listFilename = UsedFilesListFilename;
if (File.Exists(listFilename))
Expand Down
Loading