Expand testEnumUnionString comment with upstream-bug context#605
Expand testEnumUnionString comment with upstream-bug context#605YogeshKothari26 wants to merge 1 commit into
Conversation
Documents that the disabled test reflects an upstream Hive 2.3.9 parser bug (CREATE VIEW UNION ALL with Avro enum vs string column), not a Coral schema-merge regression. Notes that the case stays unsupported in Coral CI but does not surface against HMS servers on Hive 1.1.0.
883013c to
2681c80
Compare
|
if its a parser bug, does is mean its a hive 2.3 client side bug? we have internal view creation pipelines which use spark (and spark is internally using hive 2.3 client libs). is that job impacted or not? |
|
@aastha25 — verified Spark CREATE VIEW path is not impacted by this bug. Test: Created a Hive-backed Avro table with an enum column, ran the equivalent Why Spark is safe: Spark parses CREATE VIEW DDL with its own The bug fires only when Hive's parser is directly invoked (e.g. Hive CLI, embedded Hive in Coral's |
What changes are proposed in this pull request, and why are they necessary?
Documents context for the disabled
testEnumUnionStringtest (disabled in #585):SemanticAnalyzerthrowsAssertionErrorinUnparseTranslator.addTranslationduringCREATE VIEWparse for a UNION ALL between an Avro enum column and a string column.mergeUnionSchema(added in #282) is unaffected and still produces a correct STRING-typed schema for already-created views at translation time.Comment-only change.
How was this patch tested?
./gradlew :coral-schema:spotlessCheck— PASS. No code change.