[Coral-Common] Rename dialect-agnostic Hive classes to Coral names#591
Open
wmoustafa wants to merge 1 commit into
Open
[Coral-Common] Rename dialect-agnostic Hive classes to Coral names#591wmoustafa wants to merge 1 commit into
wmoustafa wants to merge 1 commit into
Conversation
Create new Coral-named classes containing all logic for classes that are not actually Hive-specific: - HiveTypeSystem -> CoralTypeSystem - HiveRelBuilder -> CoralRelBuilder - HiveUncollect -> CoralUncollect - LocalMetastoreHiveDbSchema -> LocalMetastoreDbSchema - LocalMetastoreHiveSchema -> LocalMetastoreSchema - RelDataTypeToHiveTypeStringConverter -> RelDataTypeToTypeStringConverter Update ToRelConverter to use CoralTypeSystem and CoralRelBuilder. Original Hive-named classes are retained as @deprecated thin wrappers for backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Several classes in
coral-commonhave "Hive" in their name despite being dialect-agnostic Calcite extensions with no actual Hive dependencies. This is confusing for contributors and consumers who assume these classes are Hive-specific. This PR renames them to use "Coral" names that accurately reflect their purpose.Renames (6 classes):
HiveTypeSystemCoralTypeSystemHiveRelBuilderCoralRelBuilderHiveUncollectCoralUncollectLocalMetastoreHiveDbSchemaLocalMetastoreDbSchemaLocalMetastoreHiveSchemaLocalMetastoreSchemaRelDataTypeToHiveTypeStringConverterRelDataTypeToTypeStringConverterToRelConverteris updated to useCoralTypeSystemandCoralRelBuilder.Original Hive-named classes are retained as
@Deprecatedthin wrappers (extend or delegate) for backward compatibility. No breaking changes.How was this patch tested?
./gradlew :coral-common:compileJava— compiles successfully./gradlew :coral-hive:compileJava :coral-spark:compileJava :coral-trino:compileJava— downstream modules compile against deprecated wrappers