Restore transform testing and add one new transform test.#1815
Open
xStrom wants to merge 1 commit into
Open
Conversation
xStrom
added
masonry
Contributor
|
Should we not have a lint that checks for unused .rs files in /src directory? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #1322 moved the transform tests to a new location,
mod.rswas not updated to actually include it in the compilation graph. Since then, the transform test code has started rotting.This PR here restores these tests, with the required modifications to use the latest APIs.
The blue box size was reduced because the larger size is not critical for the tests, but it did cause the pointer test snapshot to be over 8 KB, which is a soft limit we want to adhere to.
This PR also adds a new test to verify that transforms are respected when calculating the translation between content-box and window space.