Fix Portal::set_viewport_pos dirty flag choice.#1814
Merged
Conversation
xStrom
added
masonry
PoignardAzur
approved these changes
May 28, 2026
Contributor
PoignardAzur
left a comment
PoignardAzur
left a comment
There was a problem hiding this comment.
I think the reason we did that was to force the child scrollbars to run a layout pass for some reason? Either way, probably not necessary anymore.
Member
Author
|
I think that line might predate the compose pass even? Not sure, but it definitely predates work in this Linebender repo. Either way, theoretically it should work and I haven't encountered issues yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portal::set_viewport_poswas requesting layout, but that isn't actually needed. Just compose is enough for scroll translation. Other methods ofPortalalready correctly request compose.