Skip to content

fix(twake-mui): Name the dialog buttons in Mongolian - #224

Closed
Crash-- wants to merge 1 commit into
mainfrom
fix/dialogs-mn-locale
Closed

Crash-- wants to merge 1 commit into
mainfrom
fix/dialogs-mn-locale

Conversation

@Crash--

@Crash-- Crash-- commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Context

In Mongolian, a screen reader announces the close button of a dialog as Dialogs.closeButton: the locales of Dialogs have no mn.

Solution

Adds mn with the close and back button names. The other 15 keys of these locales (shortcut.*, installFlagshipApp.*) stay out: they need someone who reads Mongolian, and they remain raw as they are today.

Summary by CodeRabbit

  • New Features
    • Added Mongolian translations for dialog close and back buttons, allowing them to display as “Хаах” and “Буцах” when Mongolian is selected.
  • Tests
    • Added coverage verifying that the dialog’s close and back buttons display their Mongolian labels.

The close and back buttons announced their translation key in Mongolian, the
Dialogs locales have no mn.
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a0eef2f0-cf70-4487-8521-5a9c9b3c5830
Commits

Reviewing files that changed from the base of the PR and between b315d2a and 7cf08d7.

Files selected for processing: 3
  • packages/twake-mui/src/components/Dialogs/StandardDialog.test.tsx
  • packages/twake-mui/src/components/Dialogs/locales/index.ts
  • packages/twake-mui/src/components/Dialogs/locales/mn.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The dialog locale catalog now includes Mongolian translations for the close and back buttons. The exported locale collection registers Mongolian. A test checks that the dialog buttons have the Mongolian accessible names.

Suggested reviewers: jf-cozy

Priority: Normal

Change: Bug fix

Merge Risk: Minimal · up to 7cf08

No actionable merge-blocking risk remains in this focused localization change.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding Mongolian names for the dialog buttons.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Crash-- Crash-- closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant