Repository navigation
chore: lint with rslint and format with rs fmt - #207
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
JF-Cozy
reviewed
Oct 28, 2026
| ] | ||
| }, | ||
| ...react(lint), | ||
| // Rslint does not read the @(ts|tsx) globs of the storybook configs |
Member
Author
There was a problem hiding this comment.
For the moment it can't, if we want it we should open an issue in rslint
| @@ -1,5 +1,5 @@ | |||
| .u-debug { | |||
| background: rgba(0, 0, 0, .075); | |||
| background: rgba(0, 0, 0, 0.075); | |||
Collaborator
There was a problem hiding this comment.
still ; at the end. If it's not necessary, I suppose there is no rules in rslint for scss files, maybe we should add one?
Member
Author
There was a problem hiding this comment.
rslint does not lint scss unfortunately. If we want scss linting we need to add stylelint alongside
zatteo
marked this pull request as ready for review
October 28, 2026 10:53
makeTypography already returns TypographyVariantsOptions, and the object checks against it without the assertion. Assisted-by: LLM
A single rstack.config.mjs at the root replaces the ESLint configs of
twake-icons and twake-mui: npm run lint runs rs lint on their src
folders, with the same ignores, and a new CI step runs rs fmt --check.
rs fmt leaves out the generated icons and the changelogs, which
semantic-release writes. tsconfig.eslint.json of twake-icons only served
ESLint.
Rslint does not implement these rules, which are no longer checked:
prettier/prettier (replaced by rs fmt --check), spaced-comment and
import/no-extraneous-dependencies. rslint-config-cozy-app does not
enable the React Compiler rules of eslint-plugin-react-hooks either.
The storybook rules still run, as a JS plugin of Rslint, which installs
eslint as its peer dependency. Rslint does not read the @(ts|tsx) globs
of the storybook configs, so the config rewrites them as {ts,tsx}:
otherwise react-hooks/rules-of-hooks would report the hooks of story
render functions.
The lockfile resolves @rslib/core, a dependency of rstack, to 1.0.3:
1.0.4 depends on @rsbuild/core ~2.3.0-beta.0, which would install
another copy of rsbuild and Rspack.
Assisted-by: LLM
Assisted-by: LLM
Assisted-by: LLM
JF-Cozy
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
twake-icons and twake-mui are now linted with Rslint (
rs lint), and the repository is formatted withrs fmt, throughrslint-config-cozy-app0.2.0.eslint-config-cozy-appis removed, with theeslint.config.mjsof both packages.rstack.config.mjsat the root.npm run lintrunsrs linton thesrcfolders of twake-icons and twake-mui, with the same ignores as before.npm run fmtformats the code, and a new CI step runsnpm run lint:fmt. The generated icons and the changelogs written by semantic-release are left out.npm run linttakes 2s instead of 15 to 17s (4 CPUs, no cache). The format check takes 1s.prettier/prettier(replaced byrs fmt --check),spaced-commentandimport/no-extraneous-dependencies. The React Compiler rules ofeslint-plugin-react-hooksare no longer checked either.@(ts|tsx)globs of the storybook configs, so the config rewrites them as{ts,tsx}.makeTypography.rs fmtand the import order each get their own commit.rs fmtalso formats the SCSS of twake-css: indist/vars.css, the shadows now span several lines, which browsers read the same. In the JS ofdist, only the order of imports changes.@rslib/core, a dependency ofrstack, to 1.0.3: 1.0.4 would install another copy of rsbuild and Rspack.