You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewing files that changed from the base of the PR and between 2bf4c86 and 9c52e0f.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
The public-link toolbar now offers a folder download when the displayed folder has an ID and requests a selection-wide archive download. Tests cover root and subfolder downloads, mobile behavior, explicit selections, and missing folder IDs. An end-to-end test downloads a shared folder as a ZIP and checks root and nested file paths and contents. E2E prerequisites now list host unzip.
Possibly related issues
Issue 4452: The change exercises a whole-folder public-link download, which is the activity named in the issue objective. The summaries do not describe access-history recording.
Change: Bug fix
Merge Risk: Minimal · previous review 2bf4c
The change downloads the displayed folder itself, with archive contents covered by tests. No concrete merge-blocking issue remains; merge after normal checks pass.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly and concisely identifies the main change: downloading the displayed public folder.
Description check
The description directly explains the folder download behavior and the added E2E coverage.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 4 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 87f5762 and 2bf4c86.
Files selected for processing: 5
docs/e2e.md
e2e/pages/PublicLinkPage.ts
e2e/tests/z-link-sharing.spec.ts
src/modules/public/PublicToolbarByLink.jsx
src/modules/public/PublicToolbarByLink.spec.jsx
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
No findings reaching Minor. The download wiring is correct: download({ isSelectAll: true, displayedFolder }) makes download.jsx:59-61 archive [displayedFolder.id], which FileCollection.downloadArchive sends as POST /files/archive with ids: [folderId], so the stack zips the folder itself (verified in cozy-client@61.0.1FileCollection.js and the stack model/vfs/archive.go naming a.Name + "/" + relpath). The displayedFolder?.id && guard is safely filtered by makeActions (helpers.js), and explicit selection downloads still go through the separate PublicFolderView action array, so they are unaffected.
Details
I opened the changed files plus their callers (PublicToolbar, PublicFolderView, LightFileViewer), download.jsx/utils.js, useDisplayedFolder, useCurrentFolderId, the cozy-ui makeActions helper, cozy-client@61.0.1FileCollection, and the stack archive source, and could not construct a failure scenario.
Things I could not check in this run: I did not execute Jest or Playwright (no node_modules in the workspace), so the new spec and E2E test are only reviewed statically. The E2E test's ZIP structure assumption matches the stack source I read, but the suite itself was not run.
I opened the changed files and their callers (PublicToolbar, PublicFolderView, LightFileViewer, PublicToolbarMoreMenu, DrivePage/PublicLinkPage), the download action and downloadFiles (src/modules/actions/download.jsx:57-63, utils.js:36-48), useDisplayedFolder/useCurrentFolderId, the public routes (AppRouter.jsx), and the cozy-ui makeActions helper at the pinned version cozy-ui@143.0.0 (react/ActionsMenu/Actions/helpers.js: actions.filter(Boolean).map(actionFn => actionFn(options))). The displayedFolder?.id && (options => download({ ...options, isSelectAll: true, displayedFolder })) entry is therefore filtered out when the id is missing, and download with isSelectAll builds [displayedFolder], which downloadFiles turns into downloadArchive([displayedFolder.id]). This mirrors the existing desktop behaviour in src/modules/drive/Toolbar/components/MoreMenu.jsx:96 (files={[displayedFolder]}), so the pattern is already established.
I also read cozy-client@61.0.1/cozy-stack-client@61.0.0FileCollection (downloadArchive → createArchiveLinkByIds posting to /files/archive with attributes.ids) and the stack model/vfs/archive.go on master (zw.Create(a.Name + "/" + name + "/")), which confirms the E2E expectation files/<folder>/... and that a folder id produces an archive rooted at the folder name. Explicit selection downloads are unaffected: they go through the separate PublicFolderView actions array (PublicFolderView.jsx:143-160) where isSelectAll is not set. LightFileViewer passes a single file, so the toolbar more-menu never renders there (files.length > 1).
I could not run Jest or Playwright in this run (no node_modules), so the new spec and E2E test are reviewed statically only; the ZIP-structure assumption matches the stack source I read but the suite was not executed.
Non-blocking, pre-existing (not introduced here): isMoreMenuDisplayed = files.length > 1 (PublicToolbarByLink.jsx:33) means a public folder with 0 or 1 item shows no more menu, so the new folder-download action — and the stack download event it is meant to trigger — is unreachable for a single-item public folder. The diff does not touch that gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Summary
Why
To detect a download event on public link folder, we need the main folder of a public link to be downloaded and not its children.