Tobemerged 4.6.0 - #9
Open
bastien-roucaries wants to merge 340 commits into
Open
Conversation
…especting-until Make use of until parameter in nextMonthly function
…ith_groups Fix setting properties with group assignment
Prepare Release 4.3.5
tests: migrate from Travis to GitHub-Actions
Coverage in CI and minor edit to README
Fix deprecated usages and return types on PHP 8.1
sync ci.yml to match other repos
Changes that should have happened for 4.3.6
changelog and VERSION bump for 4.3.7
EventIterator returns wrong endTime (sabre-io#534)
[4.5] chore: prepare release 4.5.9
[4.6] feat(VCard): add getByTypes method (sabre-io#717)
Systems without the tzdata-legacy package, i.e. (Ubuntu 24.04+) reject deprecated names. Examples: Europe/Kiev, Asia/Calcutta, America/Godthab This causes FindFromTimezoneMap::find() to throw. Update all 13 occurrences across windowszones, lotuszones and exchangezones maps to their canonical replacements and wrap DateTimeZone instantiation in try/catch for resilience against future renames. Comes with unit test
…ames-4.6 [4.6] fix: Update deprecated timezone names
chore: prepare release 4.6.0
When serializing PERIOD values to JSON (for jCal format), preserve the 'Z' timezone indicator for UTC datetimes. This ensures FREEBUSY periods maintain explicit UTC designation, avoiding timezone ambiguity. Without this change: FREEBUSY:20120226T230000Z/20120226T230000Z => serializes to: ["2012-02-26T23:00:00", "2012-02-26T23:00:00"] With this change: FREEBUSY:20120226T230000Z/20120226T230000Z => serializes to: ["2012-02-26T23:00:00Z", "2012-02-26T23:00:00Z"] This behavior is consistent with RFC 5545 which requires UTC times to be designated with the 'Z' suffix. Related: sabre-io#411
Before this commit processMessageReply did not work for exceptions with a reccurent id in an other timezone than the dtstart of the master event.
…fied instances only
…json serialization
…change not very significant
The three tests were failing because DTSTAMP is now generated in the iTip messages but wasn't expected in the test assertions. Added DTSTAMP:**ANY** to the expected outputs to match the actual behavior. Fixed tests: - BrokerNewEventTest::testSimpleInviteWithAlarm - BrokerUpdateEventTest::testSimpleInviteWithAlarm - BrokerUpdateEventTest::testLocationChange 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Test case for linagora/esn-sabre#50 When DTSTART is in April but RRULE specifies BYMONTH=5 (May) and BYMONTHDAY=15, the first occurrence should be May 15, not April 15. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
When a YEARLY recurrence rule specifies BYMONTH (and optionally BYMONTHDAY/BYDAY), and the DTSTART is in a different month than those specified in BYMONTH, the first occurrence should be the first valid date according to the rule, not the DTSTART itself. For example, with: - DTSTART: April 11, 2030 - RRULE: FREQ=YEARLY;BYMONTH=5;BYMONTHDAY=15 The first occurrence should be May 15, 2030 (not April 11 or April 15). This fix modifies rewind() to check if the DTSTART is a valid occurrence according to BYMONTH rules, and if not, advances to the first valid occurrence. Fixes: linagora/esn-sabre#50 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
PHP 7.1 tests were failing due to PHP CS-Fixer compatibility issues. Since PHP 7.1 is EOL, removing it from the CI pipeline. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
CF bastien-roucaries#1 attemps to fix failed test |
Member
|
CF linagora/esn-sabre#371 the LNG test suite passes with this set of changes |
Adapt new tests for a67f6e4
Member
|
Member
|
That's weird because linagora/esn-sabre#371 passed... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.