Tobemerged 4.5.8 - #7
Open
bastien-roucaries wants to merge 324 commits into
Open
Conversation
Add .gitattributes
Explicitly select PHP 8.0 in CI
Use latest php-cs-fixer 2.17.1
Some tests were testing a bug that caused an infinite loop. Annotate those tests with large, small annotations. Turn on enforceTimeLimit, failOnWarning and failOnRisky so that the annotations are enforced when unit tests are run. Add phpunit/php-invoker to the composer require-dev becaause this is required to make the enforceTimeLimit setting effective.
Reassign modified date in yearly rrule
Prepare Release 4.3.4
…especting-until Make use of until parameter in nextMonthly function
…ith_groups Fix setting properties with group assignment
Prepare Release 4.3.5
[4.5] Fixed problem with variable scope
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
[4.5] fix: use RDATE in time range check and use all instances
[4.5] chore(deps): bump actions/cache from 4 to 5 (sabre-io#744)
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
[4.5] fix: send participation reply on fresh event
[4.5] Fixed cornercase for recurrent event for organizer and no attendee
[4.5] Improve error check in Mimedir parser
Prepare 4.5.8
When serializing PERIOD values to JSON (for jCal format), preserve the 'Z' timezone indicator for UTC datetimes. This ensures FREEBUSY periods maintain explicit UTC designation, avoiding timezone ambiguity. Without this change: FREEBUSY:20120226T230000Z/20120226T230000Z => serializes to: ["2012-02-26T23:00:00", "2012-02-26T23:00:00"] With this change: FREEBUSY:20120226T230000Z/20120226T230000Z => serializes to: ["2012-02-26T23:00:00Z", "2012-02-26T23:00:00Z"] This behavior is consistent with RFC 5545 which requires UTC times to be designated with the 'Z' suffix. Related: sabre-io#411
Before this commit processMessageReply did not work for exceptions with a reccurent id in an other timezone than the dtstart of the master event.
…fied instances only
…json serialization
…change not very significant
The three tests were failing because DTSTAMP is now generated in the iTip messages but wasn't expected in the test assertions. Added DTSTAMP:**ANY** to the expected outputs to match the actual behavior. Fixed tests: - BrokerNewEventTest::testSimpleInviteWithAlarm - BrokerUpdateEventTest::testSimpleInviteWithAlarm - BrokerUpdateEventTest::testLocationChange 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Test case for linagora/esn-sabre#50 When DTSTART is in April but RRULE specifies BYMONTH=5 (May) and BYMONTHDAY=15, the first occurrence should be May 15, not April 15. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
When a YEARLY recurrence rule specifies BYMONTH (and optionally BYMONTHDAY/BYDAY), and the DTSTART is in a different month than those specified in BYMONTH, the first occurrence should be the first valid date according to the rule, not the DTSTART itself. For example, with: - DTSTART: April 11, 2030 - RRULE: FREQ=YEARLY;BYMONTH=5;BYMONTHDAY=15 The first occurrence should be May 15, 2030 (not April 11 or April 15). This fix modifies rewind() to check if the DTSTART is a valid occurrence according to BYMONTH rules, and if not, advances to the first valid occurrence. Fixes: linagora/esn-sabre#50 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
PHP 7.1 tests were failing due to PHP CS-Fixer compatibility issues. Since PHP 7.1 is EOL, removing it from the CI pipeline. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
@chibenwa could you test this branch ?
I will add also a 4.5.9 and 4.6.0 branch