Linagora waiting merges 4.5 - #4
Open
guimard wants to merge 297 commits into
Open
Conversation
These entries should be in the developer's global .gitignore
Various infra changes
Replace assertRegExp with assertMatchesRegularExpression in unit test
fix an incomplete phpdoc type annotation
Release 4.3.1
Test with PHP8.0
…mezone Remove US/Pacific-New obsolete timezone
Add .gitattributes
add phpdoc return types for arrayaccess methods (fixes sabre-io#563)
chore(deps): bump codecov/codecov-action from 4 to 5
'Amsterdam, Berlin, Bern, Rom, Stockholm, Wien' => 'Europe/Berlin',
[4.5] Add timezone Europe/Berlin
chore: prepare 4.5.7
When serializing PERIOD values to JSON (for jCal format), preserve the 'Z' timezone indicator for UTC datetimes. This ensures FREEBUSY periods maintain explicit UTC designation, avoiding timezone ambiguity. Without this change: FREEBUSY:20120226T230000Z/20120226T230000Z => serializes to: ["2012-02-26T23:00:00", "2012-02-26T23:00:00"] With this change: FREEBUSY:20120226T230000Z/20120226T230000Z => serializes to: ["2012-02-26T23:00:00Z", "2012-02-26T23:00:00Z"] This behavior is consistent with RFC 5545 which requires UTC times to be designated with the 'Z' suffix. Related: sabre-io#411
Before this commit processMessageReply did not work for exceptions with a reccurent id in an other timezone than the dtstart of the master event.
…fied instances only
…json serialization
…change not very significant
Member
|
The failures are trivial We just need to adapt those 3 tests in order to ignore |
The three tests were failing because DTSTAMP is now generated in the iTip messages but wasn't expected in the test assertions. Added DTSTAMP:**ANY** to the expected outputs to match the actual behavior. Fixed tests: - BrokerNewEventTest::testSimpleInviteWithAlarm - BrokerUpdateEventTest::testSimpleInviteWithAlarm - BrokerUpdateEventTest::testLocationChange 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
Done |
PHP 7.1 tests were failing due to PHP CS-Fixer compatibility issues. Since PHP 7.1 is EOL, removing it from the CI pipeline. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
\o/ !!! |
Test case for linagora/esn-sabre#50 When DTSTART is in April but RRULE specifies BYMONTH=5 (May) and BYMONTHDAY=15, the first occurrence should be May 15, not April 15. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
@guimard ci failures here... |
When a YEARLY recurrence rule specifies BYMONTH (and optionally BYMONTHDAY/BYDAY), and the DTSTART is in a different month than those specified in BYMONTH, the first occurrence should be the first valid date according to the rule, not the DTSTART itself. For example, with: - DTSTART: April 11, 2030 - RRULE: FREQ=YEARLY;BYMONTH=5;BYMONTHDAY=15 The first occurrence should be May 15, 2030 (not April 11 or April 15). This fix modifies rewind() to check if the DTSTART is a valid occurrence according to BYMONTH rules, and if not, advances to the first valid occurrence. Fixes: linagora/esn-sabre#50 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
guimard
force-pushed
the
linagora-waiting-merges-4.5
branch
from
December 4, 2025 08:07
89dfaa5 to
df65b24
Compare
chibenwa
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of old patches into 4.5.7