Repository navigation
fix: Copy office sessions in the memory store - #5168
Open
taratatach wants to merge 1 commit into
Open
taratatach wants to merge 1 commit into
taratatach wants to merge 1 commit into
Conversation
The memory store of the OnlyOffice sessions kept the session it was given, and `GetDoc` returned a pointer to the stored one: a caller changing a session it had read changed it in the store, outside the lock, and the `MD5Sum` slice stayed shared with the caller that added the session. The redis store has no such sharing, as it reads and writes JSON. `ConflictDetector.Clone` makes a deep copy of a session. The memory store clones a session when it stores it (`AddDoc`, `UpdateDoc`) and when it returns it (`GetDoc`), so that it behaves like the redis store. No caller changed a session it had read, so the behavior is unchanged today. Co-Authored-By: AI
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memory store of the OnlyOffice sessions kept the session it was
given, and
GetDocreturned a pointer to the stored one: a callerchanging a session it had read changed it in the store, outside the
lock, and the
MD5Sumslice stayed shared with the caller that addedthe session. The redis store has no such sharing, as it reads and
writes JSON.
ConflictDetector.Clonemakes a deep copy of a session. The memorystore clones a session when it stores it (
AddDoc,UpdateDoc) andwhen it returns it (
GetDoc), so that it behaves like the redisstore. No caller changes a session it has read, so the behavior is
unchanged today.
Extracted from #5135.