Repository navigation
test: Build TOS dates in UTC in lifecycle tests - #5165
Merged
Merged
Conversation
taratatach
force-pushed
the
5148-bug-in-tests
branch
from
November 4, 2026 14:22
760a48e to
308898f
Compare
shepilov
approved these changes
Nov 4, 2026
`ParseTOSVersion` reads the date of a TOS version as midnight UTC, but the `CheckTOSNotSigned` test built its versions from the local date. On a machine ahead of UTC, right after local midnight, the latest version is then still in the future and the test gets `TOSWarning` instead of `TOSBlocked`. Build the dates from the current UTC time so the test passes in any time zone and at any time of day. Co-Authored-By: AI
taratatach
force-pushed
the
5148-bug-in-tests
branch
from
November 4, 2026 19:07
308898f to
a4f6433
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseTOSVersionreads the date of a TOS version as midnight UTC, butthe
CheckTOSNotSignedtest built its versions from the local date.On a machine ahead of UTC, right after local midnight, the latest
version is then still in the future and the test gets
TOSWarninginstead of
TOSBlocked.Build the dates from the current UTC time so the test passes in any
time zone and at any time of day.
Fixes #5148