Skip to content

feat(sharing): propagate organization group changes - #5147

Open
shepilov wants to merge 3 commits into
masterfrom
feat/propagate-org-groups
Open

feat(sharing): propagate organization group changes#5147
shepilov wants to merge 3 commits into
masterfrom
feat/propagate-org-groups

Conversation

@shepilov

@shepilov shepilov commented Nov 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Propagate organization group changes to member-instance sharings with retryable jobs and pagination.
  • Preserve direct and other-group access, with regression coverage for membership changes and deletions.
  • Focused tests, race checks and lint pass. The full suite's instance-creation failure also reproduces on master.

Closes #5102.

@shepilov
shepilov requested a review from taratatach as a code owner November 2, 2026 18:25
@shepilov shepilov added the e2e:web Run Drive web E2E against this Stack PR when added label Nov 3, 2026
@shepilov
fix(job): Delete fired one-shot triggers in the in-memory scheduler
8fc6b0c 
The Redis scheduler deletes @at and @in triggers once they fire, but the
in-memory one kept them, so HasTrigger reported them as pending forever.
The trigger is not unscheduled again, as a shutdown may already have done so.
@shepilov
feat(job): Expose the execution count to workers
cb9867d 
ExecCount returns 0 on the first try, so a worker can tell a retry apart.
@shepilov
shepilov force-pushed the feat/propagate-org-groups branch from 8aa0f5d to 0a0918b Compare November 3, 2026 11:08
@shepilov shepilov mentioned this pull request Nov 3, 2026
Open
@shepilov
feat(sharing): Propagate organization group changes
bd86f57 
Organization group changes reach member-owned sharings through
share-org-groups jobs that read the current directory. Changes within
the context setting org_groups_propagation_delay, 30 seconds by default,
share one run, scheduled by a one-shot trigger on the organization
instance; group deletion is propagated right away, as only a job naming
the group may revoke it.

Each reconciliation matches contacts and members once, by email ignoring
case or else by Cozy URL, and owners notify recipients only when the
sharing changed or the job is retried.
@shepilov
shepilov force-pushed the feat/propagate-org-groups branch from 0a0918b to bd86f57 Compare November 3, 2026 14:37
@shepilov shepilov mentioned this pull request Nov 3, 2026
Draft
2 of 3 tasks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taratatach taratatach Awaiting requested review from taratatach taratatach is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

e2e:web Run Drive web E2E against this Stack PR when added

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Propagate organization group changes to member-instance sharings

1 participant

@shepilov