lock BUSYBOX_TARBALL_SHA256 to the upstream 1.36.1 digest - #5
Open
hodgesds wants to merge 1 commit into
Open
Conversation
Activates the SHA-256 verification gate landed in 626b09d (`hermeticize busybox build`). Until now the pin was empty, so `verify_busybox_tarball_sha256` printed the computed digest as a `cargo:warning` and continued — the bootstrap-only path documented on the const. Replacing the sentinel with the real digest flips the verify into fail-on-mismatch mode: any future download whose SHA-256 doesn't match this value panics with both digests so the operator can distinguish "upstream regenerated the tarball (refresh pin)" from "supply-chain tampering (investigate before the bytes hit the build)". Digest computed against https://github.com/mirror/busybox/archive/refs/tags/1_36_1.tar.gz.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activates the SHA-256 verification gate landed in 626b09d (
hermeticize busybox build). Until now the pin was empty, soverify_busybox_tarball_sha256printed the computed digest as acargo:warningand continued — the bootstrap-only path documented on the const. Replacing the sentinel with the real digest flips the verify into fail-on-mismatch mode: any future download whose SHA-256 doesn't match this value panics with both digests so the operator can distinguish "upstream regenerated the tarball (refresh pin)" from "supply-chain tampering (investigate before the bytes hit the build)".Digest computed against
https://github.com/mirror/busybox/archive/refs/tags/1_36_1.tar.gz.