WIP: Add up and down command/scripts and make portainer optional#5
WIP: Add up and down command/scripts and make portainer optional#5chregu wants to merge 7 commits into
Conversation
e8c46fc to
cd309d8
Compare
cd309d8 to
9f90f79
Compare
|
I'm not sure if we should abstract docker-compose which is already an abstraction of docker. Templates and commands are quite straightforward. Portainer is already marked as |
d16f9d5 to
e9fefaa
Compare
|
Yeah, for portainer maybe not. But there's more services in future to be added. A dnsmasq service eg. is not needed on all setups and also the ssh-agent service may only be needed on OS X (and maybe windows). So I'd like to have a better scriptable "up" command. But sure, the portainer thing is quite optional. And I'd also like to keep this "up" command optional, more of a helper for getting pontsun getting started faster for non-experts with some checks (like the .env check) And as long as "docker-compose up" still works, I don't see how such a script hurts. |
9f90f79 to
e5baf6f
Compare
| docker-compose up -d $SERVICES | ||
|
|
||
| if ! ping -c 1 -t 2 traefik.$PROJECT_DOMAIN > /dev/null 2>&1 ; then | ||
| echo "!!!! traefik.$PROJECT_DOMAIN could not be resolved. You should fix this !!!!" |
There was a problem hiding this comment.
[NITPICK] Please use >&2 at the line start, to output to stderr, not stdout.
|
Also that I can do from any place and not need to do which is much easier to remember, type, use-in-other-scripts |
# Conflicts: # containers/.env.example
e5baf6f to
fd8b7da
Compare
|
I mean we could achieve the same results with multiple docker-compose.yml files like My opinion is that we should ease the setup of local dev environment without replacing docker or docker-compose or maybe in a separated project. Moreover, we'll probably execute this command once or twice to mount it once and it will remount at every startup automatically. |
|
Ah, didn't know you can have more than one -f, good then. We seem not to agree, what this project should include and what not. So let's create a pontsun-cli project and move what my vision of this "cli" is there and leave this here pure. |
02ddea4 to
cac4c2b
Compare
|
Obsolete. That stuff will go into a new project. |
Needs #1 first merged, therefore WIP for now
scripts/pontsun upandscripts/pontsun downdocker-compose upstill works