mp_from_sbin size check

mp_err mp_from_sbin(mp_int *a, const uint8_t *buf, size_t size)

Any call with size <= 0 through this API may exhaust process memory

Suggest to return early if size <= 0

The type of size is size_t which is typically unsigned. Too much handholding, propose NOTABUG

The type of size is size_t which is typically unsigned.

So there's no negative size possible, but the case for size == 0 seems to be valid.

Line 12 in 652d70a

if ((err = mp_from_ubin(a, buf + 1, size - 1u)) != MP_OKAY) {

You are too nice for this world! ;-)
Added a check in #597

Navigation Menu