Skip to content

Commit 44ef220

Browse files
committed
test(editor): state the Bun count that did not overflow as measured
Under Bun 1.4.4 the original code passed 600,000 and overflowed from 650,000; the comments named Node's 130,000 instead.
1 parent fbaceb5 commit 44ef220

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎tests/unit/editor/cypher-completions.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ describe("cypherCompletionContext", () => {
184184

185185
/**
186186
* Each `(` is a token, and the text's list once took a line's tokens as the arguments of one call, which overflows
187-
* the stack past the arguments a runtime takes: measured on 2026-11-04, 700,000 overflowed under Bun 1.4.4 (130,000
187+
* the stack past the arguments a runtime takes: measured on 2026-11-04, 700,000 overflowed under Bun 1.4.4 (600,000
188188
* did not) and 130,000 under Node 24.22.1, whose V8 is the engine of Chrome and Edge. A million is past both.
189189
*/
190190
test("a line of 1,000,000 tokens reads to the context its end is in, as a short line does", () => {

‎tests/unit/editor/sql-scope.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ describe("statementScope", () => {
210210
/**
211211
* A level's sources and its CTE names were once added to the scope's lists as the arguments of one call, which
212212
* overflows the stack past the arguments a runtime takes: measured on 2026-11-04, 700,000 overflowed under Bun 1.4.4
213-
* (130,000 did not) and 130,000 under Node 24.22.1, whose V8 is the engine of Chrome and Edge. A million is past both.
213+
* (600,000 did not) and 130,000 under Node 24.22.1, whose V8 is the engine of Chrome and Edge. A million is past both.
214214
*/
215215
test("a FROM list of 1,000,000 tables names every one", () => {
216216
const { sources } = scopeAt(`SELECT | FROM ${"t, ".repeat(999_999)}last`);

0 commit comments

Comments
 (0)