fix(editor): collect a statement's sources and CTE names one at a time

statementScope added a level's sources and its CTE names to its lists as the arguments of one call, so a long enough FROM list or WITH list overflowed the stack in the SQL completion provider: at 700,000 under Bun 1.4.4 and at 130,000 under Node 24.22.1, the V8 of Chrome and Edge. Both are now pushed in a loop, and a list of 1,000,000 names every item.

Author: cevheri

src/lib/editor/sql-scope.ts

@@ -264,15 +264,17 @@ export function statementScope(sql: string, cursor: number): StatementScope {
     const end = depth === 0 ? sql.length : closeOf(sql, open);
     const read = readCtes(sql, open + 1, end, ctes, depth);
     ctes = read.ctes;
-    cteNames.push(...read.names);
+    // One at a time here and below, never as the arguments of one call: a level may name more CTEs and sources than a
+    // runtime takes arguments (measured: 700,000 overflowed the stack under Bun 1.4.4, and 130,000 under Node 24.22.1).
+    for (const name of read.names) cteNames.push(name);
     for (const body of read.bodies) cteBodies.add(body);
     levels.push({ open, end, ctes });
   }
 
   const sources: ScopeSource[] = [];
   for (let depth = opens.length; depth >= 0; depth--) {
     const { open, end, ctes: visible } = levels[depth];
-    sources.push(...sourcesIn(sql, open + 1, end, new Map(visible), depth));
+    for (const source of sourcesIn(sql, open + 1, end, new Map(visible), depth)) sources.push(source);
     // A CTE body is a query of its own: the statement around it is no enclosing query.
     if (cteBodies.has(open)) break;
   }

tests/unit/editor/sql-scope.test.ts

@@ -206,4 +206,21 @@ describe("statementScope", () => {
       "users",
     ]);
   });
+
+  /**
+   * A level's sources and its CTE names were once added to the scope's lists as the arguments of one call, which
+   * overflows the stack past the arguments a runtime takes: measured on 2026-11-04, 700,000 overflowed under Bun 1.4.4
+   * (130,000 did not) and 130,000 under Node 24.22.1, whose V8 is the engine of Chrome and Edge. A million is past both.
+   */
+  test("a FROM list of 1,000,000 tables names every one", () => {
+    const { sources } = scopeAt(`SELECT | FROM ${"t, ".repeat(999_999)}last`);
+    expect(sources.length).toBe(1_000_000);
+    expect(names([sources[0], sources[999_998], sources[999_999]])).toEqual(["t", "t", "last"]);
+  });
+
+  test("a WITH list of 1,000,000 CTEs names every one", () => {
+    const { ctes } = scopeAt(`WITH ${"c AS (), ".repeat(999_999)}last AS () SELECT |`);
+    expect(ctes.length).toBe(1_000_000);
+    expect([ctes[0], ctes[999_998], ctes[999_999]]).toEqual(["c", "c", "last"]);
+  });
 });