De-hardcode calling other ERFA functions in tests - #317
Merged
Conversation
Among other things `erfa_generator` translates an ERFA C test file to Python. Some of the test functions call other ERFA functions, not just the function being tested. So far the additional information for translating those function calls has been hard-coded in `erfa_generator` to a very large extent, but now `TestFunction` has an attribute that contains all other ERFA functions the test function calls, so the required information can be looked up from the corresponding `Function` instances. The called functions could be identified by inspecting the C source code, but the test function doc comments list the called functions, so it was simpler to extract the names from there.
avalentino
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Among other things
erfa_generatortranslates an ERFA C test file to Python. Some of the test functions call other ERFA functions, not just the function being tested. On currentmainthe additional information for translating those function calls is mostly hard-coded inerfa_generator, but in this PRTestFunctionhas an attribute that contains all other ERFA functions the test function calls, so the required information can be looked up from the correspondingFunctioninstances. The called functions could be identified by inspecting the C source code, but the test function doc comments list the called functions, so it is simpler to extract the names from there.There are no changes to any of the files
erfa_generatorcreates.